Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5976)

Unified Diff: chrome/browser/permissions/mock_permission_request.cc

Issue 2952003003: Log site engagement scores for permission actions (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/mock_permission_request.cc
diff --git a/chrome/browser/permissions/mock_permission_request.cc b/chrome/browser/permissions/mock_permission_request.cc
index f0b9d394eeb71c143d8138d1ebfcec1334ce4349..dfd836c667a8722773d7980b85806ad288405306 100644
--- a/chrome/browser/permissions/mock_permission_request.cc
+++ b/chrome/browser/permissions/mock_permission_request.cc
@@ -18,16 +18,15 @@ MockPermissionRequest::MockPermissionRequest()
"button",
"button",
GURL("http://www.google.com"),
- PermissionRequestType::UNKNOWN,
+ PermissionRequestType::PERMISSION_NOTIFICATIONS,
PermissionRequestGestureType::UNKNOWN) {}
-MockPermissionRequest::MockPermissionRequest(
- const std::string& text)
+MockPermissionRequest::MockPermissionRequest(const std::string& text)
: MockPermissionRequest(text,
"button",
"button",
GURL("http://www.google.com"),
- PermissionRequestType::UNKNOWN,
+ PermissionRequestType::PERMISSION_NOTIFICATIONS,
PermissionRequestGestureType::UNKNOWN) {}
MockPermissionRequest::MockPermissionRequest(
@@ -51,15 +50,14 @@ MockPermissionRequest::MockPermissionRequest(const std::string& text,
request_type,
PermissionRequestGestureType::UNKNOWN) {}
-MockPermissionRequest::MockPermissionRequest(
- const std::string& text,
- const std::string& accept_label,
- const std::string& deny_label)
+MockPermissionRequest::MockPermissionRequest(const std::string& text,
+ const std::string& accept_label,
+ const std::string& deny_label)
: MockPermissionRequest(text,
accept_label,
deny_label,
GURL("http://www.google.com"),
- PermissionRequestType::UNKNOWN,
+ PermissionRequestType::PERMISSION_NOTIFICATIONS,
PermissionRequestGestureType::UNKNOWN) {}
MockPermissionRequest::~MockPermissionRequest() {}

Powered by Google App Engine
This is Rietveld 408576698