Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5741)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2952003003: Log site engagement scores for permission actions (Closed)
Patch Set: use histogram_functions Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index c32c7b257f497c3956d23a6e316aea1604b74f3a..3def3612ce88f00f3aa4d19e2edb3390d92a4502 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -15,6 +15,10 @@
#include "chrome/browser/permissions/permission_util.h"
#include "content/public/browser/permission_type.h"
+namespace content {
+class WebContents;
+}
+
enum class PermissionRequestGestureType;
class GURL;
class PermissionRequest;
@@ -158,13 +162,10 @@ class PermissionUmaUtil {
static void PermissionPromptShown(
const std::vector<PermissionRequest*>& requests);
- // The following two functions can be combined with the PermissionPromptShown
- // metrics to calculate accept, deny and ignore rates.
- static void PermissionPromptAccepted(
- const std::vector<PermissionRequest*>& requests);
-
- static void PermissionPromptDenied(
- const std::vector<PermissionRequest*>& requests);
+ static void PermissionPromptResolved(
+ const std::vector<PermissionRequest*>& requests,
+ const content::WebContents* web_contents,
+ PermissionAction permission_action);
// Records the request type and gesture type for a shown, accepted, and denied
// prompt. Defined separately as Android must call this method explicitly
« no previous file with comments | « chrome/browser/permissions/permission_request_manager_unittest.cc ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698