chrome/browser/permissions/permission_request_manager.h - Issue 2952003003: Log site engagement scores for permission actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_manager.h

Issue 2952003003: Log site engagement scores for permission actions (Closed)

Patch Set: use histogram_functions Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_request_manager.h

diff --git a/chrome/browser/permissions/permission_request_manager.h b/chrome/browser/permissions/permission_request_manager.h

index 59fa3fe28cabcf1e55cf2a7ffd5a05b0aa68d710..b6d0ab04020c6574720663f30584177af0a67569 100644

--- a/chrome/browser/permissions/permission_request_manager.h

+++ b/chrome/browser/permissions/permission_request_manager.h

@@ -15,6 +15,7 @@

#include "content/public/browser/web_contents_observer.h"

#include "content/public/browser/web_contents_user_data.h"

+enum class PermissionAction;

class PermissionRequest;

namespace safe_browsing {

@@ -157,7 +158,7 @@ class PermissionRequestManager

// Delete the view object, finalize requests, asynchronously show a queued

// request if present.

- void FinalizeBubble();

+ void FinalizeBubble(PermissionAction permission_action);

// Cancel all pending or active requests and destroy the PermissionPrompt if

// one exists. This is called if the WebContents is destroyed or navigates its