chrome/browser/permissions/permission_request.h - Issue 2952003003: Log site engagement scores for permission actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request.h

Issue 2952003003: Log site engagement scores for permission actions (Closed)

Patch Set: use histogram_functions Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_request.h

diff --git a/chrome/browser/permissions/permission_request.h b/chrome/browser/permissions/permission_request.h

index add863213438b9b796084c5ea31bd7f6f8ff04c1..ffaeb5056f47714575f7eb83db04955bbdbfcf3e 100644

--- a/chrome/browser/permissions/permission_request.h

+++ b/chrome/browser/permissions/permission_request.h

@@ -112,7 +112,7 @@ class PermissionRequest {

virtual bool ShouldShowPersistenceToggle() const;

// Used to record UMA metrics for permission requests.

- virtual PermissionRequestType GetPermissionRequestType() const;

+ virtual PermissionRequestType GetPermissionRequestType() const = 0;

// Used to record UMA for whether requests are associated with a user gesture.

// To keep things simple this metric is only recorded for the most popular