android_webview/browser/hardware_renderer.cc - Issue 295193002: Get rid of graphics layer anchor points, and replace with transform origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/hardware_renderer.cc

Issue 295193002: Get rid of graphics layer anchor points, and replace with transform origin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed all comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/hardware_renderer.cc

diff --git a/android_webview/browser/hardware_renderer.cc b/android_webview/browser/hardware_renderer.cc

index d1d225310116c3f103e3acbe122f84160abb9a9f..c74af8bb13ba3217adb8fc14754a3f88da3535f2 100644

--- a/android_webview/browser/hardware_renderer.cc

+++ b/android_webview/browser/hardware_renderer.cc

@@ -168,10 +168,10 @@ bool HardwareRenderer::DrawGL(bool stencil_enabled,

frame_provider_ = new cc::DelegatedFrameProvider(

resource_collection_.get(), input->frame.delegated_frame_data.Pass());

- delegated_layer_ = cc::DelegatedRendererLayer::Create(frame_provider_);

+ delegated_layer_ = cc::DelegatedRendererLayer::Create(frame_provider_);

delegated_layer_->SetBounds(gfx::Size(view_width_, view_height_));

delegated_layer_->SetIsDrawable(true);

- delegated_layer_->SetAnchorPoint(gfx::PointF(0.f, 0.f));

+ delegated_layer_->SetTransformOrigin(gfx::PointF(0.f, 0.f));

enne (OOO) 2014/06/03 23:28:51 It looks like there's a whole bunch of unnecessary

chrishtr 2014/06/03 23:41:55 Done.

root_layer_->AddChild(delegated_layer_);

} else {

« no previous file with comments | « no previous file | cc/base/math_util.h » ('j') | no next file with comments »