Issue 2951923002: Rearranging the deck chairs on the titanic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2951923002: Rearranging the deck chairs on the titanic. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More rearranging the deck chairs on the titanic. According to the comments, only closures proper have free variables. Running tests support this. So let's move it into that branch. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a721f87f994d713a5b605158df51215c59b40273

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	pkg/compiler/lib/src/ssa/locals_handler.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

lgtm funny - I learned that phrase just earlier today!

3 years, 6 months ago (2017-06-21 03:58:48 UTC) #3

Emily Fortuna

3 years, 6 months ago (2017-06-21 17:47:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a721f87f994d713a5b605158df51215c59b40273 (presubmit successful).