Issue 2951803004: [vm-service] Encode ticks directly as integers, since they are expect to stay in JS integer range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2951803004: [vm-service] Encode ticks directly as integers, since they are expect to stay in JS integer range. (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
cbernaschina

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[vm-service] Encode ticks directly as integers, since they are expect to stay in JS integer range. Fixes #29957 R=cbernaschina@google.com Committed: https://github.com/dart-lang/sdk/commit/bcb4fcfa11a273ae340f31f4e8cba2de6a816ba2

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	runtime/observatory/lib/src/cpu_profile/cpu_profile.dart	View		3 chunks	+8 lines, -6 lines	0 comments	Download
	M	runtime/vm/profiler_service.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 6 months ago (2017-06-22 16:50:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bcb4fcfa11a273ae340f31f4e8cba2de6a816ba2 (presubmit successful).