ios/chrome/browser/ui/browser_view_controller.mm - Issue 2951753002: Replace a DCHECK in BVC with an early return.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2951753002: Replace a DCHECK in BVC with an early return. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 1beacd5bfcf280a37bc1afa71678e7b0c02942bd..adaa0ab67e7bf9b1b7ea48b014b778f3ba1a5740 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -4404,7 +4404,9 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

}

- (void)updateFindBar:(BOOL)initialUpdate shouldFocus:(BOOL)shouldFocus {

- DCHECK([_model currentTab]);

+ if (![_model currentTab]) {

rohitrao (ping after 24h) 2017/06/20 14:02:44 Consider adding a link to the crbug and explaining

stkhapugin 2017/06/20 14:09:42 Done.

+ return;

+ }

auto* helper = FindTabHelper::FromWebState([_model currentTab].webState);

if (helper && helper->IsFindUIActive()) {

if (initialUpdate && !_isOffTheRecord) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »