Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2951723002: Add closure_test for kernel based members (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add closure_test for kernel based members + change id_equivalence_test to check kernel from .dill R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/0600f0ad9a09e86289958466828533976c43cf96

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -165 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 4 chunks +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 5 chunks +12 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/kernel/closure.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 5 chunks +16 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 5 chunks +33 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/bad_output_io_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 1 2 chunks +92 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence.dart View 1 6 chunks +15 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 1 4 chunks +209 lines, -61 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_test.dart View 1 3 chunks +137 lines, -41 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 1 chunk +14 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/inference/send_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-20 14:00:02 UTC) #2
Emily Fortuna
lgtm!
3 years, 6 months ago (2017-06-20 18:00:04 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-21 07:53:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0600f0ad9a09e86289958466828533976c43cf96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698