Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2333)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest_base.cc

Issue 2951713002: RTCPeerConnection.addTrack and removeTrack added (behind flag) (Closed)
Patch Set: Addressed guidou's comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_browsertest_base.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
index 1d76576bbd0ad7562172c7f5d6b7ed95eda0afe5..df5eb4ac07a86df4540b893fc645cfb607df1d47 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
@@ -13,6 +13,7 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
@@ -595,3 +596,37 @@ void WebRtcTestBase::VerifyRtpReceivers(
: "verifyRtpReceivers()";
EXPECT_EQ("ok-receivers-verified", ExecuteJavascript(javascript, tab));
}
+
+std::vector<std::string> WebRtcTestBase::CreateAndAddAudioAndVideoTrack(
+ content::WebContents* tab,
+ StreamArgumentType stream_argument_type) const {
+ const char* string_argument_type_str = nullptr;
+ switch (stream_argument_type) {
+ case StreamArgumentType::NO_STREAM:
+ string_argument_type_str = "'no-stream'";
+ break;
+ case StreamArgumentType::SHARED_STREAM:
+ string_argument_type_str = "'shared-stream'";
+ break;
+ case StreamArgumentType::INDIVIDUAL_STREAMS:
+ string_argument_type_str = "'individual-streams'";
+ break;
+ }
+ std::string result =
+ ExecuteJavascript(base::StringPrintf("createAndAddAudioAndVideoTrack(%s)",
+ string_argument_type_str),
+ tab);
+ EXPECT_TRUE(base::StartsWith(result, "ok-", base::CompareCase::SENSITIVE));
+ std::vector<std::string> ids = base::SplitString(
+ result.substr(3), " ", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
+ EXPECT_EQ(4u, ids.size());
+ return ids;
+}
+
+void WebRtcTestBase::RemoveTrack(content::WebContents* tab,
+ const std::string& track_id) const {
+ EXPECT_EQ(
+ "ok-sender-removed",
+ ExecuteJavascript(
+ base::StringPrintf("removeTrack('%s')", track_id.c_str()), tab));
+}

Powered by Google App Engine
This is Rietveld 408576698