[cr-action-menu] Fix anchoring to offscreen elements.

ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{
  *   top: number,
  *   left: number,
  *   width: (number| undefined),
  *   height: (number| undefined),
@@ skipping 55 matching lines @@
       break;
   }
 
   if (startPoint + length > max)
     startPoint = end - length;
   if (startPoint < min)
     startPoint = start;
   return startPoint;
 }
 
-
 /**
  * @private
  * @return {!ShowConfig}
  */
 function getDefaultShowConfig() {
   return {
     top: 0,
     left: 0,
     height: 0,
     width: 0,
     anchorAlignmentX: AnchorAlignment.AFTER_START,
     anchorAlignmentY: AnchorAlignment.AFTER_START,
-    minX: 0,
-    minY: 0,
-    maxX: window.innerWidth,
-    maxY: window.innerHeight,
+    minX: document.body.scrollLeft,
+    minY: document.body.scrollTop,
+    maxX: document.body.scrollLeft + window.innerWidth,
+    maxY: document.body.scrollTop + window.innerHeight,
   };
 }
 
 Polymer({
   is: 'cr-action-menu',
   extends: 'dialog',
 
   /**
    * List of all options in this action menu.
    * @private {?NodeList<!Element>}
@@ skipping 142 matching lines @@
     HTMLDialogElement.prototype.close.call(this);
     if (this.anchorElement_) {
       cr.ui.focusWithoutInk(assert(this.anchorElement_));
       this.anchorElement_ = null;
     }
   },
 
   /**
    * Shows the menu anchored to the given element.
    * @param {!Element} anchorElement
+   * @param {ShowConfig=} opt_config
    */
-  showAt: function(anchorElement) {
+  showAt: function(anchorElement, opt_config) {
     this.anchorElement_ = anchorElement;
+    // Scroll the anchor element into view so that the bounding rect will be
+    // accurate for where the menu should be shown.
     this.anchorElement_.scrollIntoViewIfNeeded();
+    var config = getDefaultShowConfig();
+
+    // Save the scroll position that ensures the anchor element is onscreen.
+    var scrollLeft = document.body.scrollLeft;
+    var scrollTop = document.body.scrollTop;
+
+    // Reset position so that layout isn't affected by the previous position,
+    // and so that the dialog is positioned at the top-start corner of the
+    // document.
+    this.resetStyle_();
+
+    // Show the dialog which will focus the top-start of the body. This makes
+    // the client rect calculation relative to the top-start of the body.
+    this.showModal();
+
     var rect = this.anchorElement_.getBoundingClientRect();
-    this.showAtPosition({
-      top: rect.top,
-      left: rect.left,
-      height: rect.height,
-      width: rect.width,
-      // Default to anchoring towards the left.
-      anchorAlignmentX: AnchorAlignment.BEFORE_END,
-    });
+    this.positionDialog_(/** @type {ShowConfig} */ (Object.assign(
+        config, {
+          top: rect.top,
+          left: rect.left,
+          height: rect.height,
+          width: rect.width,
+          // Default to anchoring towards the left.
+          anchorAlignmentX: AnchorAlignment.BEFORE_END,
+        },
+        opt_config)));
+
+    // Restore the scroll position.
+    document.body.scrollTop = scrollTop;
+    document.body.scrollLeft = scrollLeft;
+
+    this.addCloseListeners_();
   },
 
   /**
    * Shows the menu anchored to the given box. The anchor alignment is
    * specified as an X and Y alignment which represents a point in the anchor
    * where the menu will align to, which can have the menu either before or
    * after the given point in each axis. Center alignment places the center of
    * the menu in line with the center of the anchor.
    *
    *            y-start
    *         _____________
    *         |           |
    *         |           |
    *         |   CENTER  |
    * x-start |     x     | x-end
    *         |           |
    *         |anchor box |
    *         |___________|
    *
    *             y-end
    *
    * For example, aligning the menu to the inside of the top-right edge of
    * the anchor, extending towards the bottom-left would use a alignment of
    * (BEFORE_END, AFTER_START), whereas centering the menu below the bottom
    * edge of the anchor would use (CENTER, AFTER_END).
    *
    * @param {!ShowConfig} config
    */
   showAtPosition: function(config) {
+    this.resetStyle_();
+    this.showModal();
+    this.positionDialog_(config);
+    this.addCloseListeners_();
+  },
+
+  /** @private */
+  resetStyle_: function() {
+    this.style.left = '';
+    this.style.right = '';
+    this.style.top = '0';

[dpapad, 2017/06/22 01:36:40]

Should this be '0px' ?

[calamity, 2017/06/22 06:41:41]

It's convention for 0 to be used in place of 0px.

+  },
+
+  /**
+   * @param {!ShowConfig} config
+   * @private
+   */
+  positionDialog_: function(config) {
     var c = Object.assign(getDefaultShowConfig(), config);

[dpapad, 2017/06/22 01:36:40]

positionDialog_() is called from both showAtPosition() and showAt(). The latter
already calls getDefaultShowConfig() and passes a config object that is fully
populated. Can we do the same for showAtPostion() and stop calling Object.assign
here.

This way getDefaultShowConfig() will not called twice when someone uses
showAt().

[calamity, 2017/06/22 06:41:41]

Replaced the other call instead. This getDefaultShowConfig is nice here because
it guarantees all the values accessed below will be defined.

 
     var top = c.top;
     var left = c.left;
     var bottom = top + c.height;
     var right = left + c.width;
 
-    this.boundClose_ = this.boundClose_ || function() {
-      if (this.open)
-        this.close();
-    }.bind(this);
-    window.addEventListener('resize', this.boundClose_);
-    window.addEventListener('popstate', this.boundClose_);
-
-    // Reset position to prevent previous values from affecting layout.
-    this.style.left = '';
-    this.style.right = '';
-    this.style.top = '';
-
-    this.showModal();
-
     // Flip the X anchor in RTL.
     var rtl = getComputedStyle(this).direction == 'rtl';
     if (rtl)
       c.anchorAlignmentX *= -1;
 
     var menuLeft = getStartPointWithAnchor(
         left, right, this.offsetWidth, c.anchorAlignmentX, c.minX, c.maxX);
 
     if (rtl) {
-      var menuRight = window.innerWidth - menuLeft - this.offsetWidth;
+      var menuRight = document.body.scrollWidth - menuLeft - this.offsetWidth;
       this.style.right = menuRight + 'px';
     } else {
       this.style.left = menuLeft + 'px';
     }
 
     var menuTop = getStartPointWithAnchor(
         top, bottom, this.offsetHeight, c.anchorAlignmentY, c.minY, c.maxY);
     this.style.top = menuTop + 'px';
   },
+
+  /**
+   * @private
+   */
+  addCloseListeners_: function() {
+    this.boundClose_ = this.boundClose_ || function() {
+      if (this.open)
+        this.close();
+    }.bind(this);
+    window.addEventListener('resize', this.boundClose_);
+    window.addEventListener('popstate', this.boundClose_);
+  },
 });
 })();