Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.h

Issue 2951643003: Add UMA that periodically logs number of outstanding requests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.h
diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h
index 3f5aa959c691d7b6d091ec99a4a24a06c1ffc08a..d55439788aae11c03694069df6fd6b021da5fd61 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.h
+++ b/content/browser/loader/resource_dispatcher_host_impl.h
@@ -513,6 +513,10 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// Checks all pending requests and updates the load info if necessary.
void UpdateLoadInfo();
+ // Records statistics about outstanding requests since last call, and reset
Takashi Toyoshima 2017/06/20 07:39:22 s/last/the last/ ?
Kunihiko Sakamoto 2017/06/20 08:39:28 Done.
+ // the stats.
+ void RecordOutstandingRequestsStats();
+
// Resumes or cancels (if |cancel_requests| is true) any blocked requests.
void ProcessBlockedRequestsForRoute(
const GlobalFrameRoutingId& global_routing_id,
@@ -710,6 +714,10 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// not empty and at least one RenderViewHost is loading.
std::unique_ptr<base::RepeatingTimer> update_load_states_timer_;
+ // A timer that periodically calls RecordOutstandingRequestsStats.
+ std::unique_ptr<base::RepeatingTimer>
+ record_outstanding_requests_stats_timer_;
+
// Request ID for browser initiated requests. request_ids generated by
// child processes are counted up from 0, while browser created requests
// start at -2 and go down from there. (We need to start at -2 because -1 is
@@ -763,6 +771,15 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// Largest number of outstanding requests seen so far in any single process.
int largest_outstanding_request_per_process_count_seen_;
+ // Largest number of outstanding requests seen since last call to
Takashi Toyoshima 2017/06/20 07:39:22 the last
Kunihiko Sakamoto 2017/06/20 08:39:28 Done.
+ // RecordOutstandingRequestsStats.
+ int peak_outstanding_request_count_;
+
+ // Largest number of outstanding requests seen while there are outstanding
+ // requests from two or more processes, since last call to
Takashi Toyoshima 2017/06/20 07:39:21 the last
Kunihiko Sakamoto 2017/06/20 08:39:28 Done.
+ // RecordOutstandingRequestsStats.
+ int peak_outstanding_request_count_multitab_ = 0;
+
// Time of the last user gesture. Stored so that we can add a load
// flag to requests occurring soon after a gesture to indicate they
// may be because of explicit user action.

Powered by Google App Engine
This is Rietveld 408576698