Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: Source/modules/indexeddb/IDBFactory.cpp

Issue 295163005: Remove ScriptState::current() from IDBRequest (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBFactory.h ('k') | Source/modules/indexeddb/IDBFactory.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBFactory.cpp
diff --git a/Source/modules/indexeddb/IDBFactory.cpp b/Source/modules/indexeddb/IDBFactory.cpp
index 2e8190b871dcb66c8475a1f817a5cc2a71cebd48..6412ffb44136b98a825a6d812fde7f339ccdc2d9 100644
--- a/Source/modules/indexeddb/IDBFactory.cpp
+++ b/Source/modules/indexeddb/IDBFactory.cpp
@@ -75,38 +75,38 @@ static bool isContextValid(ExecutionContext* context)
return true;
}
-IDBRequest* IDBFactory::getDatabaseNames(ExecutionContext* context, ExceptionState& exceptionState)
+IDBRequest* IDBFactory::getDatabaseNames(ScriptState* scriptState, ExceptionState& exceptionState)
{
IDB_TRACE("IDBFactory::getDatabaseNames");
- if (!isContextValid(context))
- return 0;
- if (!context->securityOrigin()->canAccessDatabase()) {
+ if (!isContextValid(scriptState->executionContext()))
+ return nullptr;
+ if (!scriptState->executionContext()->securityOrigin()->canAccessDatabase()) {
exceptionState.throwSecurityError("access to the Indexed Database API is denied in this context.");
return 0;
}
- IDBRequest* request = IDBRequest::create(context, IDBAny::createNull(), 0);
+ IDBRequest* request = IDBRequest::create(scriptState, IDBAny::createNull(), 0);
- if (!m_permissionClient->allowIndexedDB(context, "Database Listing")) {
+ if (!m_permissionClient->allowIndexedDB(scriptState->executionContext(), "Database Listing")) {
request->onError(DOMError::create(UnknownError, permissionDeniedErrorMessage));
return request;
}
- blink::Platform::current()->idbFactory()->getDatabaseNames(WebIDBCallbacksImpl::create(request).leakPtr(), createDatabaseIdentifierFromSecurityOrigin(context->securityOrigin()));
+ blink::Platform::current()->idbFactory()->getDatabaseNames(WebIDBCallbacksImpl::create(request).leakPtr(), createDatabaseIdentifierFromSecurityOrigin(scriptState->executionContext()->securityOrigin()));
return request;
}
-IDBOpenDBRequest* IDBFactory::open(ExecutionContext* context, const String& name, unsigned long long version, ExceptionState& exceptionState)
+IDBOpenDBRequest* IDBFactory::open(ScriptState* scriptState, const String& name, unsigned long long version, ExceptionState& exceptionState)
{
IDB_TRACE("IDBFactory::open");
if (!version) {
exceptionState.throwTypeError("The version provided must not be 0.");
return 0;
}
- return openInternal(context, name, version, exceptionState);
+ return openInternal(scriptState, name, version, exceptionState);
}
-IDBOpenDBRequest* IDBFactory::openInternal(ExecutionContext* context, const String& name, int64_t version, ExceptionState& exceptionState)
+IDBOpenDBRequest* IDBFactory::openInternal(ScriptState* scriptState, const String& name, int64_t version, ExceptionState& exceptionState)
{
blink::Platform::current()->histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBOpenCall, IDBMethodsMax);
ASSERT(version >= 1 || version == IDBDatabaseMetadata::NoIntVersion);
@@ -114,33 +114,33 @@ IDBOpenDBRequest* IDBFactory::openInternal(ExecutionContext* context, const Stri
exceptionState.throwTypeError("The name provided must not be empty.");
return 0;
}
- if (!isContextValid(context))
- return 0;
- if (!context->securityOrigin()->canAccessDatabase()) {
+ if (!isContextValid(scriptState->executionContext()))
+ return nullptr;
+ if (!scriptState->executionContext()->securityOrigin()->canAccessDatabase()) {
exceptionState.throwSecurityError("access to the Indexed Database API is denied in this context.");
return 0;
}
IDBDatabaseCallbacks* databaseCallbacks = IDBDatabaseCallbacks::create();
int64_t transactionId = IDBDatabase::nextTransactionId();
- IDBOpenDBRequest* request = IDBOpenDBRequest::create(context, databaseCallbacks, transactionId, version);
+ IDBOpenDBRequest* request = IDBOpenDBRequest::create(scriptState, databaseCallbacks, transactionId, version);
- if (!m_permissionClient->allowIndexedDB(context, name)) {
+ if (!m_permissionClient->allowIndexedDB(scriptState->executionContext(), name)) {
request->onError(DOMError::create(UnknownError, permissionDeniedErrorMessage));
return request;
}
- blink::Platform::current()->idbFactory()->open(name, version, transactionId, WebIDBCallbacksImpl::create(request).leakPtr(), WebIDBDatabaseCallbacksImpl::create(databaseCallbacks).leakPtr(), createDatabaseIdentifierFromSecurityOrigin(context->securityOrigin()));
+ blink::Platform::current()->idbFactory()->open(name, version, transactionId, WebIDBCallbacksImpl::create(request).leakPtr(), WebIDBDatabaseCallbacksImpl::create(databaseCallbacks).leakPtr(), createDatabaseIdentifierFromSecurityOrigin(scriptState->executionContext()->securityOrigin()));
return request;
}
-IDBOpenDBRequest* IDBFactory::open(ExecutionContext* context, const String& name, ExceptionState& exceptionState)
+IDBOpenDBRequest* IDBFactory::open(ScriptState* scriptState, const String& name, ExceptionState& exceptionState)
{
IDB_TRACE("IDBFactory::open");
- return openInternal(context, name, IDBDatabaseMetadata::NoIntVersion, exceptionState);
+ return openInternal(scriptState, name, IDBDatabaseMetadata::NoIntVersion, exceptionState);
}
-IDBOpenDBRequest* IDBFactory::deleteDatabase(ExecutionContext* context, const String& name, ExceptionState& exceptionState)
+IDBOpenDBRequest* IDBFactory::deleteDatabase(ScriptState* scriptState, const String& name, ExceptionState& exceptionState)
{
IDB_TRACE("IDBFactory::deleteDatabase");
blink::Platform::current()->histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBDeleteDatabaseCall, IDBMethodsMax);
@@ -148,28 +148,28 @@ IDBOpenDBRequest* IDBFactory::deleteDatabase(ExecutionContext* context, const St
exceptionState.throwTypeError("The name provided must not be empty.");
return 0;
}
- if (!isContextValid(context))
- return 0;
- if (!context->securityOrigin()->canAccessDatabase()) {
+ if (!isContextValid(scriptState->executionContext()))
+ return nullptr;
+ if (!scriptState->executionContext()->securityOrigin()->canAccessDatabase()) {
exceptionState.throwSecurityError("access to the Indexed Database API is denied in this context.");
return 0;
}
- IDBOpenDBRequest* request = IDBOpenDBRequest::create(context, 0, 0, IDBDatabaseMetadata::DefaultIntVersion);
+ IDBOpenDBRequest* request = IDBOpenDBRequest::create(scriptState, nullptr, 0, IDBDatabaseMetadata::DefaultIntVersion);
- if (!m_permissionClient->allowIndexedDB(context, name)) {
+ if (!m_permissionClient->allowIndexedDB(scriptState->executionContext(), name)) {
request->onError(DOMError::create(UnknownError, permissionDeniedErrorMessage));
return request;
}
- blink::Platform::current()->idbFactory()->deleteDatabase(name, WebIDBCallbacksImpl::create(request).leakPtr(), createDatabaseIdentifierFromSecurityOrigin(context->securityOrigin()));
+ blink::Platform::current()->idbFactory()->deleteDatabase(name, WebIDBCallbacksImpl::create(request).leakPtr(), createDatabaseIdentifierFromSecurityOrigin(scriptState->executionContext()->securityOrigin()));
return request;
}
-short IDBFactory::cmp(ExecutionContext* context, const ScriptValue& firstValue, const ScriptValue& secondValue, ExceptionState& exceptionState)
+short IDBFactory::cmp(ScriptState* scriptState, const ScriptValue& firstValue, const ScriptValue& secondValue, ExceptionState& exceptionState)
{
- IDBKey* first = scriptValueToIDBKey(toIsolate(context), firstValue);
- IDBKey* second = scriptValueToIDBKey(toIsolate(context), secondValue);
+ IDBKey* first = scriptValueToIDBKey(scriptState->isolate(), firstValue);
+ IDBKey* second = scriptValueToIDBKey(scriptState->isolate(), secondValue);
ASSERT(first);
ASSERT(second);
« no previous file with comments | « Source/modules/indexeddb/IDBFactory.h ('k') | Source/modules/indexeddb/IDBFactory.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698