[Night Light] CL9: Add localization for time's AM and PM

chrome/browser/resources/settings/device_page/night_light_slider.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * night-light-slider is used to set the custom automatic schedule of the
  * Night Light feature, so that users can set their desired start and end
  * times.
  */
@@ skipping 173 matching lines @@
    * (which is the slider bar).
    * @param {HTMLDivElement} knob Either one of the two knobs.
    * @return {number}
    * @private
    */
   getKnobRatio_: function(knob) {
     return parseFloat(knob.style.left) / this.$.sliderBar.offsetWidth;
   },
 
   /**
-   * Pads the given number |num| with leading zeros such that its length as a
-   * string is 2.
-   * @param {number} num
-   * @return {string}
-   * @private
-   */
-  pad2_: function(num) {
-    var s = String(num);
-    if (s.length == 2)
-      return s;
-
-    return '0' + s;
-  },
-
-  /**
    * Converts the |offsetMinutes| value (which the number of minutes since
-   * 00:00) to its string representation in the format 6:30 PM.
+   * 00:00) to its language-sensitive time string representation.
    * @param {number} offsetMinutes The time of day represented as the number of
    * minutes from 00:00.
    * @return {string}
    * @private
    */
   offsetMinutesToTimeString_: function(offsetMinutes) {
-    // TODO(afakhry): Check if these values need to be localized.
     var hour = Math.floor(offsetMinutes / 60);
-    var amPm = hour >= 12 ? ' PM' : ' AM';
-    hour %= 12;
-    hour = hour == 0 ? 12 : hour;
     var minute = Math.floor(offsetMinutes % 60);
-    return hour + ':' + this.pad2_(minute) + amPm;
+
+    var d = new Date(Date.now());

[stevenjb, 2017/06/20 17:25:56]

I think this is the same as Date() ?

[afakhry, 2017/06/20 18:10:34]

Done.

+    d.setHours(hour);
+    d.setMinutes(minute);
+    d.setSeconds(0);
+    d.setMilliseconds(0);
+
+    return d.toLocaleTimeString([], {hour: '2-digit', minute:'2-digit'});
   },
 
   /**
    * Handles changes in the start and end times prefs.
    * @private
    */
   customTimesChanged_: function() {
     var startOffsetMinutes = /** @type {number} */(
         this.getPref('ash.night_light.custom_start_time').value);
     this.startTime_ = this.offsetMinutesToTimeString_(startOffsetMinutes);
@@ skipping 206 matching lines @@
    */
   onRightKey_: function(e) {
     e.preventDefault();
     var knobPref = this.getFocusedKnobPrefPathIfAny_();
     if (!knobPref)
       return;
 
     this.incrementPref_(knobPref, 1);
   },
 });