[Night Light] CL9: Add localization for time's AM and PM

chrome/browser/resources/settings/device_page/night_light_slider.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * night-light-slider is used to set the custom automatic schedule of the
  * Night Light feature, so that users can set their desired start and end
  * times.
  */
@@ skipping 196 matching lines @@
 
   /**
    * Converts the |offsetMinutes| value (which the number of minutes since
    * 00:00) to its string representation in the format 6:30 PM.
    * @param {number} offsetMinutes The time of day represented as the number of
    * minutes from 00:00.
    * @return {string}
    * @private
    */
   offsetMinutesToTimeString_: function(offsetMinutes) {
-    // TODO(afakhry): Check if these values need to be localized.
     var hour = Math.floor(offsetMinutes / 60);
-    var amPm = hour >= 12 ? ' PM' : ' AM';
+    var amPm = hour >= 12 ? this.i18n('displayNightLightTimePm')
+                          : this.i18n('displayNightLightTimeAm');
     hour %= 12;
     hour = hour == 0 ? 12 : hour;
     var minute = Math.floor(offsetMinutes % 60);
-    return hour + ':' + this.pad2_(minute) + amPm;
+    return hour + ':' + this.pad2_(minute) + ' ' + amPm;

[stevenjb, 2017/06/20 00:36:43]

Looking around, it seems like we should be using Date.toLocaleTimeString here
instead?

[afakhry, 2017/06/20 16:47:43]

Oh Wow, I had no idea about this. Thank you very much! This is much easier.
Done.

   },
 
   /**
    * Handles changes in the start and end times prefs.
    * @private
    */
   customTimesChanged_: function() {
     var startOffsetMinutes = /** @type {number} */(
         this.getPref('ash.night_light.custom_start_time').value);
     this.startTime_ = this.offsetMinutesToTimeString_(startOffsetMinutes);
@@ skipping 206 matching lines @@
    */
   onRightKey_: function(e) {
     e.preventDefault();
     var knobPref = this.getFocusedKnobPrefPathIfAny_();
     if (!knobPref)
       return;
 
     this.incrementPref_(knobPref, 1);
   },
 });