Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2048)

Unified Diff: base/time/time_win_unittest.cc

Issue 2951413003: Add UMA for High Resolution Timer Usage (Closed)
Patch Set: Added suspend / resume logic Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/time/time_win_unittest.cc
diff --git a/base/time/time_win_unittest.cc b/base/time/time_win_unittest.cc
index 17c722300d681d67d0010503bace12773b236585..b81701455ee6a5a17cf03363f6f8d2a408aded10 100644
--- a/base/time/time_win_unittest.cc
+++ b/base/time/time_win_unittest.cc
@@ -300,4 +300,40 @@ TEST(TimeDelta, ConstexprInitialization) {
EXPECT_EQ(kExpectedDeltaInMilliseconds, kConstexprTimeDelta.InMilliseconds());
}
+TEST(HighResolutionTimer, GetUsage) {
+ EXPECT_EQ(0.0, Time::GetHighResolutionTimerUsage());
+
+ Time::ResetHighResolutionTimerUsage();
+ EXPECT_EQ(0.0, Time::GetHighResolutionTimerUsage());
gab 2017/06/28 16:39:33 Why is this guaranteed? Can't Now() tick between R
stanisc 2017/06/28 22:28:35 Since the high resolution timer isn't activated ye
+
+ Sleep(10);
+ // 0% usage since the timer isn't activated.
+ EXPECT_EQ(0.0, Time::GetHighResolutionTimerUsage());
+
+ Time::ActivateHighResolutionTimer(true);
+ Time::ResetHighResolutionTimerUsage();
+
+ Sleep(20);
+ // 100% usage since the timer has been activated entire time.
+ EXPECT_EQ(100.0, Time::GetHighResolutionTimerUsage());
+
+ Time::ActivateHighResolutionTimer(false);
+ Sleep(20);
+ double usage1 = Time::GetHighResolutionTimerUsage();
+ // usage1 should be about 50%.
+ EXPECT_LT(usage1, 100.0);
+ EXPECT_GT(usage1, 0.0);
gab 2017/06/28 16:39:33 Precise enough to use EXPECT_NEAR? (and below)
stanisc 2017/06/28 22:28:35 In my experience anything involving time checks is
+
+ Time::ActivateHighResolutionTimer(true);
+ Sleep(10);
+ Time::ActivateHighResolutionTimer(false);
+ double usage2 = Time::GetHighResolutionTimerUsage();
+ // usage2 should be about 60%.
+ EXPECT_LT(usage2, 100.0);
+ EXPECT_GT(usage2, usage1);
+
+ Time::ResetHighResolutionTimerUsage();
+ EXPECT_EQ(0.0, Time::GetHighResolutionTimerUsage());
+}
+
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698