Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2951413002: Reland of Change memory dumps to not use periodic dumps by default. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org, tracing+reviews_chromium.org, danakj+watch_chromium.org, ssid
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Change memory dumps to not use periodic dumps by default. (patchset #1 id:1 of https://codereview.chromium.org/2952693002/ ) Reason for revert: Relanding the original CL. Periodic dumping on Android should be fixed: https://codereview.chromium.org/2948023002/ Original issue's description: > Revert of Change memory dumps to not use periodic dumps by default. (patchset #3 id:40001 of https://codereview.chromium.org/2912483002/ ) > > Reason for revert: > This breaks periodic dumping on Android. Reverting. > > Original issue's description: > > Change memory dumps to not use periodic dumps by default. > > > > The only consumer that requires periodic dumps [and doesn't specify an explicit > > dump config] is Chrome tracing, so explicitly specify a periodic dump config > > there. Remove by default the periodic dump config. > > > > BUG=726393 > > > > Review-Url: https://codereview.chromium.org/2912483002 > > Cr-Commit-Position: refs/heads/master@{#475608} > > Committed: https://chromium.googlesource.com/chromium/src/+/0529413d84c06f3720bf4a56b28bb2c7358cefd1 > > TBR=primiano@chromium.org,ssid@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=726393 > > Review-Url: https://codereview.chromium.org/2952693002 > Cr-Commit-Position: refs/heads/master@{#480941} > Committed: https://chromium.googlesource.com/chromium/src/+/8b0b2a16a1e141102620e7d173271197cd6b7f3d TBR=primiano@chromium.org,ssid@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=726393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/trace_event/trace_config.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
erikchen
Created Reland of Change memory dumps to not use periodic dumps by default.
3 years, 6 months ago (2017-06-22 23:20:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951413002/1
3 years, 6 months ago (2017-06-22 23:21:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/471651) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-22 23:24:44 UTC) #5
Primiano Tucci (use gerrit)
3 years, 6 months ago (2017-06-23 09:39:05 UTC) #7
Message was sent while issue was closed.
I guess this is abandoned in favor of
https://codereview.chromium.org/2952083004/?

Powered by Google App Engine
This is Rietveld 408576698