milo/build_source/buildbucket/builder.go - Issue 2951393002: [errors] de-specialize Transient in favor of Tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/build_source/buildbucket/builder.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)

Patch Set: copyright Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/build_source/buildbucket/builder.go

diff --git a/milo/build_source/buildbucket/builder.go b/milo/build_source/buildbucket/builder.go

index 5a5a83ed7c1b8e923f9885b0920c9b2b40813a56..4df715f347601b8e3ab1a8c0e51509d2b62155d4 100644

--- a/milo/build_source/buildbucket/builder.go

+++ b/milo/build_source/buildbucket/builder.go

@@ -43,7 +43,7 @@ func search(c context.Context, client *buildbucket.Service, req *buildbucket.Sea

var err error

res, err = req.Do()

if apiErr, ok := err.(*googleapi.Error); ok && apiErr.Code >= 500 {

- err = errors.WrapTransient(apiErr)

+ err = retry.Tag.Apply(apiErr)

}

return err