logdog/client/butler/output/pubsub/pubsubOutput.go - Issue 2951393002: [errors] de-specialize Transient in favor of Tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/client/butler/output/pubsub/pubsubOutput.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)

Patch Set: copyright Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: logdog/client/butler/output/pubsub/pubsubOutput.go

diff --git a/logdog/client/butler/output/pubsub/pubsubOutput.go b/logdog/client/butler/output/pubsub/pubsubOutput.go

index 841c34b10f208a0e96f04fa8820789b42e1530e0..05bfb2e30890593568d318e605aab7c299408b7d 100644

--- a/logdog/client/butler/output/pubsub/pubsubOutput.go

+++ b/logdog/client/butler/output/pubsub/pubsubOutput.go

@@ -205,7 +205,7 @@ func (o *pubSubOutput) publishMessage(message *pubsub.Message) error {

messageID, err = o.Topic.Publish(ctx, message)

if err == context.DeadlineExceeded {

// If we hit our publish deadline, retry.

- err = errors.WrapTransient(err)

+ err = retry.Tag.Apply(err)

} else {

err = grpcutil.WrapIfTransient(err)

}