Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: common/gcloud/gs/writer.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)
Patch Set: copyright Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« common/errors/tags.go ('K') | « common/gcloud/gs/gs.go ('k') | common/lhttp/client.go » ('j') | grpc/grpcutil/errors.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/gcloud/gs/writer.go
diff --git a/common/gcloud/gs/writer.go b/common/gcloud/gs/writer.go
index cb3b6ef43499cfce8926eabfde273ca98b1a8cb8..7713bc057526739be87aeccff4824116f0a1d4e4 100644
--- a/common/gcloud/gs/writer.go
+++ b/common/gcloud/gs/writer.go
@@ -9,7 +9,6 @@ import (
"time"
gs "cloud.google.com/go/storage"
- "github.com/luci/luci-go/common/errors"
log "github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/common/retry"
"golang.org/x/net/context"
@@ -46,7 +45,7 @@ func (w *prodWriter) Write(d []byte) (a int, err error) {
a, ierr = w.Writer.Write(d)
// Assume all Write errors are transient.
- ierr = errors.WrapTransient(ierr)
+ ierr = retry.Tag.Apply(ierr)
return
}, func(err error, d time.Duration) {
log.Fields{
« common/errors/tags.go ('K') | « common/gcloud/gs/gs.go ('k') | common/lhttp/client.go » ('j') | grpc/grpcutil/errors.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698