appengine/datastorecache/cache.go - Issue 2951393002: [errors] de-specialize Transient in favor of Tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/datastorecache/cache.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)

Patch Set: copyright Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/datastorecache/cache.go

diff --git a/appengine/datastorecache/cache.go b/appengine/datastorecache/cache.go

index 3b5d38f2f30060030875b3f806a79051d4a2250f..841349b4e614af8dc0643f22223097c576549d56 100644

--- a/appengine/datastorecache/cache.go

+++ b/appengine/datastorecache/cache.go

@@ -336,7 +336,7 @@ func (bci *boundCacheInst) get(c context.Context, key []byte) (Value, error) {

case ErrFailedToLock:

// Retry after delay.

- return errors.WrapTransient(err)

+ return retry.Tag.Apply(err)

dnj 2017/06/24 14:53:54 I don't like "retry.Tag.Apply" as a way of express

iannucci 2017/06/24 20:16:09 Done.

default:

log.WithError(err).Warningf(c, "Unexpected failure obtaining initial load lock.")

« no previous file with comments | « no previous file | appengine/gaeauth/client/client.go » ('j') | common/errors/annotate.go » ('J')