Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: tumble/process.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)
Patch Set: more refactor Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tumble/process.go
diff --git a/tumble/process.go b/tumble/process.go
index afc8907f0dbf4effcccae455b3ab15292d2da02c..dde479d44be6394f87cad1bb85ee148e562624ef 100644
--- a/tumble/process.go
+++ b/tumble/process.go
@@ -16,6 +16,7 @@ import (
"github.com/luci/luci-go/common/data/stringset"
"github.com/luci/luci-go/common/errors"
"github.com/luci/luci-go/common/logging"
+ "github.com/luci/luci-go/common/retry/transient"
"github.com/luci/luci-go/common/sync/parallel"
"github.com/luci/gae/filter/txnBuf"
@@ -233,7 +234,7 @@ func (t *processTask) process(c context.Context, cfg *Config, q *ds.Query) error
numProcessed, errCount, transientErrCount)
switch {
case transientErrCount > 0:
- return errors.WrapTransient(errors.New("transient error during shard processing"))
+ return errors.New("transient error during shard processing", transient.Tag)
case errCount > 0:
return errors.New("encountered non-transient error during shard processing")
}

Powered by Google App Engine
This is Rietveld 408576698