Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tokenserver/appengine/impl/utils/bqlog/bqlog_test.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)
Patch Set: more refactor Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tokenserver/appengine/impl/utils/bqlog/bqlog_test.go
diff --git a/tokenserver/appengine/impl/utils/bqlog/bqlog_test.go b/tokenserver/appengine/impl/utils/bqlog/bqlog_test.go
index 573ccd7b2664d041d4047394a2a107b1732fa5b4..faebac0398c2c885e5e542798d559473037cf7e8 100644
--- a/tokenserver/appengine/impl/utils/bqlog/bqlog_test.go
+++ b/tokenserver/appengine/impl/utils/bqlog/bqlog_test.go
@@ -25,6 +25,7 @@ import (
"github.com/luci/luci-go/common/data/rand/mathrand"
"github.com/luci/luci-go/common/data/stringset"
"github.com/luci/luci-go/common/errors"
+ "github.com/luci/luci-go/common/retry/transient"
. "github.com/smartystreets/goconvey/convey"
)
@@ -266,7 +267,7 @@ func TestFlush(t *testing.T) {
}
testingLog.insertMock = func(_ context.Context, r *bigquery.TableDataInsertAllRequest) (*bigquery.TableDataInsertAllResponse, error) {
- return nil, errors.WrapTransient(fmt.Errorf("omg, transient error"))
+ return nil, errors.New("omg, transient error", transient.Tag)
}
tc.SetTimerCallback(func(d time.Duration, t clock.Timer) {

Powered by Google App Engine
This is Rietveld 408576698