Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: milo/build_source/buildbucket/builder.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)
Patch Set: more refactor Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/build_source/buildbucket/builder.go
diff --git a/milo/build_source/buildbucket/builder.go b/milo/build_source/buildbucket/builder.go
index 5a5a83ed7c1b8e923f9885b0920c9b2b40813a56..28b9b2b42e7060a4d67fc11281aefe7ee01ecd20 100644
--- a/milo/build_source/buildbucket/builder.go
+++ b/milo/build_source/buildbucket/builder.go
@@ -24,6 +24,7 @@ import (
"github.com/luci/luci-go/common/errors"
"github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/common/retry"
+ "github.com/luci/luci-go/common/retry/transient"
"github.com/luci/luci-go/common/sync/parallel"
"github.com/luci/luci-go/milo/api/resp"
@@ -38,12 +39,12 @@ func search(c context.Context, client *buildbucket.Service, req *buildbucket.Sea
var res *buildbucket.ApiSearchResponseMessage
err := retry.Retry(
c,
- retry.TransientOnly(retry.Default),
+ transient.Only(retry.Default),
func() error {
var err error
res, err = req.Do()
if apiErr, ok := err.(*googleapi.Error); ok && apiErr.Code >= 500 {
- err = errors.WrapTransient(apiErr)
+ err = transient.Tag.Apply(apiErr)
}
return err
},

Powered by Google App Engine
This is Rietveld 408576698