Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: logdog/common/archive/archive.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)
Patch Set: more refactor Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« grpc/grpcutil/errors.go ('K') | « logdog/client/butler/output/pubsub/pubsubOutput.go ('k') | logdog/common/storage/bigtable/bigtable.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/common/archive/archive.go
diff --git a/logdog/common/archive/archive.go b/logdog/common/archive/archive.go
index a7f409e4feef6e41f756d1f91bcc4d11272af34b..6fcf62d571ba55bb4a125448a2745484b65311ac 100644
--- a/logdog/common/archive/archive.go
+++ b/logdog/common/archive/archive.go
@@ -10,7 +10,6 @@ import (
"io"
"github.com/luci/luci-go/common/data/recordio"
- "github.com/luci/luci-go/common/errors"
"github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/common/sync/parallel"
"github.com/luci/luci-go/logdog/api/logpb"
@@ -152,10 +151,6 @@ func Archive(m Manifest) error {
}
})
- // If any of the returned errors was transient, return a transient error.
- if errors.Any(err, errors.IsTransient) {
- err = errors.WrapTransient(err)
- }
return err
}
« grpc/grpcutil/errors.go ('K') | « logdog/client/butler/output/pubsub/pubsubOutput.go ('k') | logdog/common/storage/bigtable/bigtable.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698