grpc/prpc/encoding.go - Issue 2951393002: [errors] de-specialize Transient in favor of Tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grpc/prpc/encoding.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)

Patch Set: more refactor Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: grpc/prpc/encoding.go

diff --git a/grpc/prpc/encoding.go b/grpc/prpc/encoding.go

index 0d99b819b701585640a96c191b1d6c18fde34d6a..4395e4ef7da997e3105a16a52d7125a532f0c1b6 100644

--- a/grpc/prpc/encoding.go

+++ b/grpc/prpc/encoding.go

@@ -88,7 +88,7 @@ func respondMessage(msg proto.Message, format Format) *response {

res.body = buf.Bytes()

default:

- panic(fmt.Errorf("impossible: invalid format %s", format))

+ panic(fmt.Errorf("impossible: invalid format %d", format))

}

if err != nil {