Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: common/config/validation/validation_test.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)
Patch Set: more refactor Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/config/validation/validation_test.go
diff --git a/common/config/validation/validation_test.go b/common/config/validation/validation_test.go
index ebf7c0a81479f65d389765a78034fad462f347fc..5bb17cbcc436eb613b45df9324111c5c38ca358e 100644
--- a/common/config/validation/validation_test.go
+++ b/common/config/validation/validation_test.go
@@ -7,7 +7,6 @@ package validation
import (
"testing"
- "github.com/luci/luci-go/common/errors"
"github.com/luci/luci-go/common/logging"
. "github.com/smartystreets/goconvey/convey"
@@ -40,8 +39,13 @@ func TestValidation(t *testing.T) {
singleErr := err.(*Error).Errors[0]
So(singleErr.Error(), ShouldEqual, `in "file.cfg" (ctx 123): blah zzz`)
- So(errors.ExtractData(singleErr, "file"), ShouldEqual, "file.cfg")
- So(errors.ExtractData(singleErr, "element"), ShouldResemble, []string{"ctx 123"})
+ d, ok := fileTag.In(singleErr)
+ So(ok, ShouldBeTrue)
+ So(d, ShouldEqual, "file.cfg")
+
+ elts, ok := elementTag.In(singleErr)
+ So(ok, ShouldBeTrue)
+ So(elts, ShouldResemble, []string{"ctx 123"})
})
Convey("Regular usage", t, func() {

Powered by Google App Engine
This is Rietveld 408576698