[errors] de-specialize Transient in favor of Tags.

tokenserver/appengine/impl/utils/bqlog/bqlog_test.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package bqlog
 
 import (
         "bytes"
         "encoding/gob"
         "encoding/json"
         "fmt"
         "math/rand"
         "sync"
         "testing"
         "time"
 
         "golang.org/x/net/context"
         bigquery "google.golang.org/api/bigquery/v2"
 
         "github.com/luci/gae/filter/featureBreaker"
         "github.com/luci/gae/service/taskqueue"
         "github.com/luci/luci-go/appengine/gaetesting"
         "github.com/luci/luci-go/common/clock"
         "github.com/luci/luci-go/common/clock/testclock"
         "github.com/luci/luci-go/common/data/rand/mathrand"
         "github.com/luci/luci-go/common/data/stringset"
         "github.com/luci/luci-go/common/errors"
+        "github.com/luci/luci-go/common/retry"
 
         . "github.com/smartystreets/goconvey/convey"
 )
 
 var testingLog = Log{
         QueueName: "pull-queue",
         ProjectID: "projectID",
         DatasetID: "datasetID",
         TableID:   "tableID",
 }
@@ skipping 221 matching lines @@
 
                         for i := 0; i < 20; i++ {
                                 err := testingLog.Insert(ctx, Entry{
                                         Data: map[string]interface{}{"i": i},
                                 })
                                 So(err, ShouldBeNil)
                                 tc.Add(time.Millisecond) // emulate passage of time to sort entries
                         }
 
                         testingLog.insertMock = func(_ context.Context, r *bigquery.TableDataInsertAllRequest) (*bigquery.TableDataInsertAllResponse, error) {
-                                return nil, errors.WrapTransient(fmt.Errorf("omg, transient error"))
+                                return nil, errors.New("omg, transient error", retry.Tag)
                         }
 
                         tc.SetTimerCallback(func(d time.Duration, t clock.Timer) {
                                 if testclock.HasTags(t, "insert-retry") {
                                         tc.Add(d)
                                 }
                         })
 
                         count, err := testingLog.Flush(ctx)
                         So(err.Error(), ShouldEqual, "omg, transient error (and 2 other errors)")
@@ skipping 43 matching lines @@
 
 func mockInsertAll(l *Log, reqs *[]*bigquery.TableDataInsertAllRequest) {
         lock := sync.Mutex{}
         l.insertMock = func(ctx context.Context, r *bigquery.TableDataInsertAllRequest) (*bigquery.TableDataInsertAllResponse, error) {
                 lock.Lock()
                 defer lock.Unlock()
                 *reqs = append(*reqs, r)
                 return &bigquery.TableDataInsertAllResponse{}, nil
         }
 }