[errors] de-specialize Transient in favor of Tags.

logdog/appengine/coordinator/endpoints/logs/get.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package logs
 
 import (
         "time"
 
         "github.com/luci/luci-go/common/errors"
         log "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/common/proto/google"
         "github.com/luci/luci-go/common/retry"
+        "github.com/luci/luci-go/common/retry/transient"
         "github.com/luci/luci-go/grpc/grpcutil"
         "github.com/luci/luci-go/logdog/api/endpoints/coordinator/logs/v1"
         "github.com/luci/luci-go/logdog/api/logpb"
         "github.com/luci/luci-go/logdog/appengine/coordinator"
         "github.com/luci/luci-go/logdog/common/storage"
         "github.com/luci/luci-go/logdog/common/types"
         "github.com/luci/luci-go/luci_config/common/cfgtypes"
 
         ds "github.com/luci/gae/service/datastore"
 
@@ skipping 179 matching lines @@
 
         sreq := storage.GetRequest{
                 Project: project,
                 Path:    path,
                 Index:   types.MessageIndex(req.Index),
                 Limit:   logCount,
         }
 
         var ierr error
         count := 0
-        err := retry.Retry(c, retry.TransientOnly(retry.Default), func() error {
+        err := retry.Retry(c, transient.Only(retry.Default), func() error {
                 // Issue the Get request. This may return a transient error, in which case
                 // we will retry.
                 return st.Get(sreq, func(e *storage.Entry) bool {
                         var le *logpb.LogEntry
                         if le, ierr = e.GetLogEntry(); ierr != nil {
                                 return false
                         }
 
                         if count > 0 && byteLimit-len(e.D) < 0 {
                                 // Not the first log, and we've exceeded our byte limit.
@@ skipping 43 matching lines @@
 }
 
 func getTail(c context.Context, st coordinator.Storage, project cfgtypes.ProjectName, path types.StreamPath) (
         []*logpb.LogEntry, error) {
         log.Fields{
                 "project": project,
                 "path":    path,
         }.Debugf(c, "Issuing Tail request.")
 
         var e *storage.Entry
-        err := retry.Retry(c, retry.TransientOnly(retry.Default), func() (err error) {
+        err := retry.Retry(c, transient.Only(retry.Default), func() (err error) {
                 e, err = st.Tail(project, path)
                 return
         }, func(err error, delay time.Duration) {
                 log.Fields{
                         log.ErrorKey: err,
                         "delay":      delay,
                 }.Warningf(c, "Transient error while fetching tail log; retrying.")
         })
         switch err {
         case nil:
                 le, err := e.GetLogEntry()
                 if err != nil {
                         log.WithError(err).Errorf(c, "Failed to load tail entry data.")
                         return nil, err
                 }
                 return []*logpb.LogEntry{le}, nil
 
         case storage.ErrDoesNotExist:
                 return nil, nil
 
         default:
                 log.WithError(err).Errorf(c, "Failed to fetch tail log.")
                 return nil, err
         }
 }