Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2951373002: Move tests {list,map}_literals_can_infer_null_top_level to inference_new (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move tests {list,map}_literals_can_infer_null_top_level to inference_new These tests' expectations reflect a drawback in analyzer's type inference--it doesn't infer the correct types lists and maps containing `null` when those structures occur outside a method body. The new front_end type inference engine does the right thing. Accordingly, we have to move the test to inference_new, so that we can update its expectations without breaking analyzer's test code. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/a7ab70eb06424e610f340d19c105599aa7b15056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -48 lines) Patch
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -2 lines 0 comments Download
D pkg/front_end/testcases/inference/list_literals_can_infer_null_top_level.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/inference/list_literals_can_infer_null_top_level.dart.strong.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/inference/map_literals_can_infer_null_top_level.dart View 1 chunk +0 lines, -10 lines 0 comments Download
A + pkg/front_end/testcases/inference_new/list_literals_can_infer_null_top_level.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/front_end/testcases/inference_new/list_literals_can_infer_null_top_level.dart.direct.expect View 1 chunk +1 line, -2 lines 0 comments Download
A pkg/front_end/testcases/inference_new/list_literals_can_infer_null_top_level.dart.outline.expect View 1 chunk +6 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference_new/list_literals_can_infer_null_top_level.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/front_end/testcases/inference_new/map_literals_can_infer_null_top_level.dart View 1 chunk +5 lines, -3 lines 0 comments Download
A + pkg/front_end/testcases/inference_new/map_literals_can_infer_null_top_level.dart.direct.expect View 1 chunk +1 line, -2 lines 0 comments Download
A pkg/front_end/testcases/inference_new/map_literals_can_infer_null_top_level.dart.outline.expect View 1 chunk +6 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference_new/map_literals_can_infer_null_top_level.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Paul Berry
3 years, 6 months ago (2017-06-22 21:17:26 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-23 12:35:21 UTC) #4
Paul Berry
3 years, 6 months ago (2017-06-23 14:40:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7ab70eb06424e610f340d19c105599aa7b15056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698