Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: net/http/transport_security_state_unittest.cc

Issue 2951343002: Remove residual support for SHA-1 public key pins. (Closed)
Patch Set: Remove the rest of HASH_VALUE_SHA1; respond to comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_state_unittest.cc
diff --git a/net/http/transport_security_state_unittest.cc b/net/http/transport_security_state_unittest.cc
index bfc8bee38b0c7cb3c25c364b8aee53cc119f4e4f..7fe9642f2d3d7c70b3d773baf3039e6e868d6a9e 100644
--- a/net/http/transport_security_state_unittest.cc
+++ b/net/http/transport_security_state_unittest.cc
@@ -14,7 +14,6 @@
#include "base/memory/ptr_util.h"
#include "base/metrics/field_trial.h"
#include "base/rand_util.h"
-#include "base/sha1.h"
#include "base/strings/string_piece.h"
#include "base/test/histogram_tester.h"
#include "base/test/mock_entropy_provider.h"
@@ -68,9 +67,6 @@ const char kExpectStapleStaticIncludeSubdomainsHostname[] =
// kGoodPath is blog.torproject.org.
const char* const kGoodPath[] = {
- "sha1/Yz4vayd/83rQfDXkDPn2yhzIScw=",
- "sha1/3lKvjNsfmrn+WmfDhvr2iVh/yRs=",
- "sha1/gzF+YoVCU9bXeDGQ7JGQVumRueM=",
"sha256/4osU79hfY3P2+WJGlT2mxmSL+5FIwLEVxTQcavyBNgQ=",
"sha256/k2v657xBsOVe1PQRwOsHsw3bsGT2VzIqz5K+59sNQws=",
"sha256/WoiWRyIOVNa9ihaBciRSC7XHjliYS9VwUGOIud4PB18=",
@@ -84,9 +80,6 @@ const char kGoodPin3[] = "WoiWRyIOVNa9ihaBciRSC7XHjliYS9VwUGOIud4PB18=";
// kBadPath is plus.google.com via Trustcenter, which is utterly wrong for
// torproject.org.
const char* const kBadPath[] = {
- "sha1/111111111111111111111111111=",
- "sha1/222222222222222222222222222=",
- "sha1/333333333333333333333333333=",
"sha256/1111111111111111111111111111111111111111111=",
"sha256/2222222222222222222222222222222222222222222=",
"sha256/3333333333333333333333333333333333333333333=",

Powered by Google App Engine
This is Rietveld 408576698