Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 2951343002: Remove residual support for SHA-1 public key pins. (Closed)
Patch Set: Remove the rest of HASH_VALUE_SHA1; respond to comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/cert_verify_proc_unittest.cc
diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc
index 2a82ac6f2dfb31a611d58e05727e73f2451e3ea0..fdb96b1d140a9ae36dc708277118142ecab7ce53 100644
--- a/net/cert/cert_verify_proc_unittest.cc
+++ b/net/cert/cert_verify_proc_unittest.cc
@@ -1310,8 +1310,7 @@ TEST_P(CertVerifyProcInternalTest, PublicKeyHashes) {
CertificateList(), &verify_result);
EXPECT_THAT(error, IsOk());
- // There are 2 hashes each of the 3 certificates in the verified chain.
- EXPECT_EQ(6u, verify_result.public_key_hashes.size());
+ EXPECT_EQ(3u, verify_result.public_key_hashes.size());
// Convert |public_key_hashes| to strings for ease of comparison.
std::vector<std::string> public_key_hash_strings;
@@ -1320,15 +1319,12 @@ TEST_P(CertVerifyProcInternalTest, PublicKeyHashes) {
std::vector<std::string> expected_public_key_hashes = {
// Target
- "sha1/eykCtxdjf+9TcP+dle4RZOcuWfI=",
"sha256/jpsUnwFFTO7e+l5zQDYhutkf7uA+dCVsWfRvv0UDX40=",
// Intermediate
- "sha1/UCuWOTyNcmLrd/Ie2jTjCHyGV7M=",
"sha256/D9u0epgvPYlG9YiVp7V+IMT+xhUpB5BhsS/INjDXc4Y=",
// Trust anchor
- "sha1/7lRAdhiny84OU7rosLno5A+v0ls=",
"sha256/VypP3VWL7OaqTJ7mIBehWYlv8khPuFHpWiearZI2YjI="};
// |public_key_hashes| does not have an ordering guarantee.

Powered by Google App Engine
This is Rietveld 408576698