net/cert/cert_verify_proc_mac.cc - Issue 2951343002: Remove residual support for SHA-1 public key pins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_mac.cc

Issue 2951343002: Remove residual support for SHA-1 public key pins. (Closed)

Patch Set: Remove the rest of HASH_VALUE_SHA1; respond to comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_mac.cc

diff --git a/net/cert/cert_verify_proc_mac.cc b/net/cert/cert_verify_proc_mac.cc

index bd6d819e702af52ece7e926d4fd1d59d2bc3fd44..269316ce69c4a20f6d674a07b6ea952790262b51 100644

--- a/net/cert/cert_verify_proc_mac.cc

+++ b/net/cert/cert_verify_proc_mac.cc

@@ -382,10 +382,6 @@ void AppendPublicKeyHashes(CFArrayRef chain,

if (!asn1::ExtractSPKIFromDERCert(der_bytes, &spki_bytes))

continue;

- HashValue sha1(HASH_VALUE_SHA1);

- CC_SHA1(spki_bytes.data(), spki_bytes.size(), sha1.data());

- hashes->push_back(sha1);

HashValue sha256(HASH_VALUE_SHA256);

CC_SHA256(spki_bytes.data(), spki_bytes.size(), sha256.data());

hashes->push_back(sha256);