net/cert/cert_verify_proc_win.cc - Issue 2951343002: Remove residual support for SHA-1 public key pins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_win.cc

Issue 2951343002: Remove residual support for SHA-1 public key pins. (Closed)

Patch Set: Remove more code, use SHA-256 for the blacklist, and include the original FRST and India CCA certs. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_win.cc

diff --git a/net/cert/cert_verify_proc_win.cc b/net/cert/cert_verify_proc_win.cc

index e94c1fc6283e83c79537265682d18934b4d79e7d..69c456b61f51a93798711b977b8a3b03950de24f 100644

--- a/net/cert/cert_verify_proc_win.cc

+++ b/net/cert/cert_verify_proc_win.cc

@@ -539,11 +539,6 @@ void AppendPublicKeyHashes(PCCERT_CHAIN_CONTEXT chain,

if (!asn1::ExtractSPKIFromDERCert(der_bytes, &spki_bytes))

continue;

- HashValue sha1(HASH_VALUE_SHA1);

- base::SHA1HashBytes(reinterpret_cast<const uint8_t*>(spki_bytes.data()),

- spki_bytes.size(), sha1.data());

- hashes->push_back(sha1);

HashValue sha256(HASH_VALUE_SHA256);

crypto::SHA256HashString(spki_bytes, sha256.data(), crypto::kSHA256Length);

hashes->push_back(sha256);