Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: net/base/hash_value.cc

Issue 2951343002: Remove residual support for SHA-1 public key pins. (Closed)
Patch Set: Remove more code, use SHA-256 for the blacklist, and include the original FRST and India CCA certs. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/cert_verify_proc.cc » ('j') | net/cert/cert_verify_proc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/hash_value.cc
diff --git a/net/base/hash_value.cc b/net/base/hash_value.cc
index 0f109405ae4a4208d827d737c10b13fff151ebcd..d7170ca0fee951bb397c73a895af2d44e3bab653 100644
--- a/net/base/hash_value.cc
+++ b/net/base/hash_value.cc
@@ -37,10 +37,7 @@ HashValue::HashValue(const SHA256HashValue& hash)
bool HashValue::FromString(const base::StringPiece value) {
base::StringPiece base64_str;
- if (value.starts_with("sha1/")) {
- tag = HASH_VALUE_SHA1;
- base64_str = value.substr(5);
- } else if (value.starts_with("sha256/")) {
+ if (value.starts_with("sha256/")) {
tag = HASH_VALUE_SHA256;
base64_str = value.substr(7);
} else {
« no previous file with comments | « no previous file | net/cert/cert_verify_proc.cc » ('j') | net/cert/cert_verify_proc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698