runtime/vm/object_graph.cc - Issue 2951333002: Moves the top_ and end_ words of the Scavenger into mutator thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_graph.cc

Issue 2951333002: Moves the top_ and end_ words of the Scavenger into mutator thread. (Closed)

Patch Set: Address comments from CL Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object_graph.cc

diff --git a/runtime/vm/object_graph.cc b/runtime/vm/object_graph.cc

index ae3678abf7b67dd4e21f3eb0af31c10f051fdb37..e716ce37cf08a6761cd0a111f8486cd33164b694 100644

--- a/runtime/vm/object_graph.cc

+++ b/runtime/vm/object_graph.cc

@@ -613,7 +613,7 @@ intptr_t ObjectGraph::Serialize(WriteStream* stream,

isolate()->heap()->CollectAllGarbage();

}

// Current encoding assumes objects do not move, so promote everything to old.

- isolate()->heap()->new_space()->Evacuate();

+ isolate()->heap()->new_space()->Evacuate(isolate()->mutator_thread());

HeapIterationScope iteration_scope(true);

RawObject* kRootAddress = reinterpret_cast<RawObject*>(kHeapObjectTag);