Moves the top_ and end_ words of the Scavenger into mutator thread.

runtime/vm/scavenger.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_SCAVENGER_H_
 #define RUNTIME_VM_SCAVENGER_H_
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/dart.h"
@@ skipping 108 matching lines @@
   // During scavenging both the to and from spaces contain "legal" objects.
   // During a scavenge this function only returns true for addresses that will
   // be part of the surviving objects.
   bool Contains(uword addr) const { return to_->Contains(addr); }
 
   RawObject* FindObject(FindObjectVisitor* visitor) const;
 
   uword TryAllocate(intptr_t size) {
     ASSERT(Utils::IsAligned(size, kObjectAlignment));
     ASSERT(heap_ != Dart::vm_isolate()->heap());
+
 #if defined(DEBUG)
     if (FLAG_gc_at_alloc && !scavenging_) {
       Scavenge();
     }
 #endif
-    uword result = top_;
-    intptr_t remaining = end_ - top_;
-    if (remaining < size) {
+
+    Thread* thread = Thread::Current();

[rmacnak, 2017/07/05 17:39:53]

This will hurt DBC as TLS is expensive. Pass in the Thread instead. 

[danunez, 2017/07/05 18:12:55]

I will do this as part of a separate function, as you suggested in a later
comment in scavenger.cc.

+    uword top = 0;
+    uword end = 0;
+
+    if (!thread->IsMutatorThread()) {
+      thread = Isolate::Current()->mutator_thread();

[rmacnak, 2017/07/05 17:39:53]

We cannot access state on another Thread outside of a SafepointOperationScope.

ASSERT(thread->IsMutator());

[danunez, 2017/07/05 18:12:56]

Can't the background thread trigger a full heap GC? This would mean a
non-mutator thread is doing new space GC, which is what I found during testing.

+    }
+
+    if (thread->heap() != NULL) {

[rmacnak, 2017/07/05 17:39:53]

This shouldn't be possible unless we haven't correctly initialized the thread.

[danunez, 2017/07/05 18:12:56]

This happens if the mutator is unscheduled, but the background thread triggers a
GC. This was how I checked if the mutator was unscheduled.

+      top = thread->top();
+      end = thread->end();
+    } else {
+      top = top_;
+      end = end_;
+    }
+
+    uword result = top;
+    intptr_t remaining = end - top;
+    if ((remaining < size) || (CapacityInWords() == 0)) {

[rmacnak, 2017/07/05 17:39:53]

Why is the second check needed? Only the VM isolate should have an empty new
space, and it should never do a new-space allocation as asserted in L128.

[danunez, 2017/07/05 18:12:56]

Correct. There is exactly one test that checks the semantics of a zero size
Scavenger in C++. This check is only for that test. I could not think of any
other way to deal with it.

I am open to suggestions.

       return 0;
     }
     ASSERT(to_->Contains(result));
     ASSERT((result & kObjectAlignmentMask) == object_alignment_);
 
-    top_ += size;
-    ASSERT(to_->Contains(top_) || (top_ == to_->end()));
+    top += size;
+    ASSERT(to_->Contains(top) || (top == to_->end()));
+
+    if (thread->heap() != NULL) {
+      thread->set_top_offset(top);
+    } else {
+      top_ = top;
+    }
+    // We only want to change top_ if mutator is scheduled and therefore
+    // has a heap attached.
+
+
     return result;
   }
 
   // Collect the garbage in this scavenger.
   void Scavenge();
   void Scavenge(bool invoke_api_callbacks);
 
   // Promote all live objects.
   void Evacuate() {
     Scavenge();
     Scavenge();
     ASSERT(UsedInWords() == 0);
   }
 
   // Accessors to generate code for inlined allocation.
   uword* TopAddress() { return &top_; }
   uword* EndAddress() { return &end_; }
-  static intptr_t top_offset() { return OFFSET_OF(Scavenger, top_); }
-  static intptr_t end_offset() { return OFFSET_OF(Scavenger, end_); }
 
   int64_t UsedInWords() const {
     return (top_ - FirstObjectStart()) >> kWordSizeLog2;
   }
   int64_t CapacityInWords() const { return to_->size_in_words(); }
   int64_t ExternalInWords() const { return external_size_ >> kWordSizeLog2; }
   SpaceUsage GetCurrentUsage() const {
     SpaceUsage usage;
     usage.used_in_words = UsedInWords();
     usage.capacity_in_words = CapacityInWords();
@@ skipping 53 matching lines @@
   uword ProcessWeakProperty(RawWeakProperty* raw_weak,
                             ScavengerVisitor* visitor);
   void Epilogue(Isolate* isolate, SemiSpace* from, bool invoke_api_callbacks);
 
   bool IsUnreachable(RawObject** p);
 
   // During a scavenge we need to remember the promoted objects.
   // This is implemented as a stack of objects at the end of the to space. As
   // object sizes are always greater than sizeof(uword) and promoted objects do
   // not consume space in the to space they leave enough room for this stack.
   void PushToPromotedStack(uword addr) {

[rmacnak, 2017/07/05 17:39:53]

Promo stack:

During a scavenge, we should be using Scavenger's top/end instead of Thread's
top/end. So all this promo stack code should not need to change.

More generally, we should not need to access TLS in the middle of scavenging.

[danunez, 2017/07/05 18:12:56]

I do not recall why I changed this to use TLS. I will change it back and use the
Epilogue to set the new top and end on the stack. By then, nothing should be
touching the heap.

     ASSERT(scavenging_);
-    end_ -= sizeof(addr);
-    ASSERT(end_ > top_);
-    *reinterpret_cast<uword*>(end_) = addr;
+
+    uword top = 0;
+    uword end = 0;
+    Thread* thread = Thread::Current();
+    if (!thread->IsMutatorThread()) {
+      thread = Isolate::Current()->mutator_thread();
+    }
+
+    if (thread->heap() != NULL) {
+      top = thread->top();
+      end = thread->end();
+    } else {
+      top = top_;
+      end = end_;
+    }
+
+    end -= sizeof(addr);
+
+    if (thread->heap() != NULL) {
+      thread->set_end_offset(end);
+    } else {
+      end_ = end;
+    }
+
+    ASSERT(end > top);
+    *reinterpret_cast<uword*>(end) = addr;
   }
   uword PopFromPromotedStack() {
     ASSERT(scavenging_);
-    uword result = *reinterpret_cast<uword*>(end_);
-    end_ += sizeof(result);
-    ASSERT(end_ <= to_->end());
+
+    uword end = 0;
+    Thread* thread = Thread::Current();
+    if (!thread->IsMutatorThread()) {
+      thread = Isolate::Current()->mutator_thread();
+    }
+
+    if (thread->heap() != NULL) {
+      end = thread->end();
+    } else {
+      end = end_;
+    }
+
+    uword result = *reinterpret_cast<uword*>(end);
+    end += sizeof(result);
+
+    if (thread->heap() != NULL) {
+      thread->set_end_offset(end);
+    } else {
+      end_ = end;
+    }
+
+    ASSERT(end <= to_->end());
     return result;
   }
   bool PromotedStackHasMore() const {
     ASSERT(scavenging_);
-    return end_ < to_->end();
+    uword end = 0;
+    Thread* thread = Thread::Current();
+    if (!thread->IsMutatorThread()) {
+      thread = Isolate::Current()->mutator_thread();
+    }
+
+    if (thread->heap() != NULL) {
+      end = thread->end();
+    } else {
+      end = end_;
+    }
+
+    return end < to_->end();
   }
 
   void UpdateMaxHeapCapacity();
   void UpdateMaxHeapUsage();
 
   void ProcessWeakReferences();
 
   intptr_t NewSizeInWords(intptr_t old_size_in_words) const;
 
   // Accessed from generated code.
@@ skipping 28 matching lines @@
   RawWeakProperty* delayed_weak_properties_;
 
   int64_t gc_time_micros_;
   intptr_t collections_;
   static const int kStatsHistoryCapacity = 2;
   RingBuffer<ScavengeStats, kStatsHistoryCapacity> stats_history_;
 
   // The total size of external data associated with objects in this scavenger.
   intptr_t external_size_;
 
+  Mutex* space_lock_;

[rmacnak, 2017/07/05 17:39:53]

Add a comment describing what this lock protects.

[danunez, 2017/07/05 18:12:56]

I will remove the lock for now. It has no purpose in this CL.

+
   friend class ScavengerVisitor;
   friend class ScavengerWeakVisitor;
 
   DISALLOW_COPY_AND_ASSIGN(Scavenger);
 };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_SCAVENGER_H_