Chromium Code Reviews| Index: tools/post_perf_builder_job.py |
| diff --git a/tools/post_perf_builder_job.py b/tools/post_perf_builder_job.py |
| index b1e4e857e1985d6a3b99d6630a7604e5f2bf9ef7..15fa1465d9fe3803a8fb78015494ebcb3977c27e 100644 |
| --- a/tools/post_perf_builder_job.py |
| +++ b/tools/post_perf_builder_job.py |
| @@ -234,25 +234,26 @@ def GetBuildStatus(build_num, bot_name, builder_host, builder_port): |
| A tuple consists of build status (SUCCESS, FAILED or PENDING) and a link |
| to build status page on the waterfall. |
| """ |
| - # Gets the buildbot url for the given host and port. |
| - server_url = _GetBuildBotUrl(builder_host, builder_port) |
| - buildbot_url = BUILDER_JSON_URL % {'server_url': server_url, |
| - 'bot_name': bot_name, |
| - 'build_num': build_num |
| - } |
| - build_data = _GetBuildData(buildbot_url) |
| results_url = None |
| - if build_data: |
| - # Link to build on the buildbot showing status of build steps. |
| - results_url = BUILDER_HTML_URL % {'server_url': server_url, |
| - 'bot_name': bot_name, |
| - 'build_num': build_num |
| - } |
| - if _IsBuildFailed(build_data): |
| - return (FAILED, results_url) |
| - |
| - elif _IsBuildSuccessful(build_data): |
| - return (OK, results_url) |
| + if build_num: |
| + # Gets the buildbot url for the given host and port. |
| + server_url = _GetBuildBotUrl(builder_host, builder_port) |
| + buildbot_url = BUILDER_JSON_URL % {'server_url': server_url, |
|
ghost stip (do not use)
2014/05/23 00:40:23
it would be ideal to use http://chrome-build-extra
prasadv
2014/05/23 17:56:19
Thank you Mike,
Can bisect bot on master4 access
|
| + 'bot_name': bot_name, |
| + 'build_num': build_num |
| + } |
| + build_data = _GetBuildData(buildbot_url) |
| + if build_data: |
| + # Link to build on the buildbot showing status of build steps. |
| + results_url = BUILDER_HTML_URL % {'server_url': server_url, |
| + 'bot_name': bot_name, |
| + 'build_num': build_num |
| + } |
| + if _IsBuildFailed(build_data): |
| + return (FAILED, results_url) |
| + |
| + elif _IsBuildSuccessful(build_data): |
| + return (OK, results_url) |
| return (PENDING, results_url) |