Check build status by parsing tryserver buildbot JSON.

tools/bisect-perf-regression.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Performance Test Bisect Tool
 
 This script bisects a series of changelists using binary search. It starts at
 a bad revision where a performance metric has regressed, and asks for a last
 known-good revision. It will then binary search across this revision range by
@@ skipping 36 matching lines @@
 import shutil
 import StringIO
 import subprocess
 import sys
 import time
 import zipfile
 
 sys.path.append(os.path.join(os.path.dirname(__file__), 'telemetry'))
 
 import bisect_utils
-import post_perf_builder_job
+import post_perf_builder_job as bisect_builder
 from telemetry.page import cloud_storage
 
 # The additional repositories that might need to be bisected.
 # If the repository has any dependant repositories (such as skia/src needs
 # skia/include and skia/gyp to be updated), specify them in the 'depends'
 # so that they're synced appropriately.
 # Format is:
 # src: path to the working directory.
 # recurse: True if this repositry will get bisected.
 # depends: A list of other repositories that are actually part of the same
@@ skipping 1548 matching lines @@
         return ('win_perf_bisect_builder', MAX_WIN_BUILD_TIME)
       if IsLinux():
         return ('linux_perf_bisect_builder', MAX_LINUX_BUILD_TIME)
       if IsMac():
         return ('mac_perf_bisect_builder', MAX_MAC_BUILD_TIME)
       raise NotImplementedError('Unsupported Platform "%s".' % sys.platform)
     if not condition:
       return False
 
     bot_name, build_timeout = GetBuilderNameAndBuildTime(self.opts.target_arch)
-
+    # Build number on the tryserver.
+    build_num = None
+    builder_host = self.opts.builder_host
+    builder_port = self.opts.builder_port
     # Create a unique ID for each build request posted to try server builders.
     # This ID is added to "Reason" property in build's json.
-    # TODO: Use this id to track the build status.
-    build_request_id = GetSHA1HexDigest('%s-%s' % (revision, patch))
+    build_request_id = GetSHA1HexDigest(
+        '%s-%s-%s' % (revision, patch, time.time()))
 
     # Creates a try job description.
-    job_args = {'host': self.opts.builder_host,
-                'port': self.opts.builder_port,
+    job_args = {'host': builder_host,
+                'port': builder_port,
                 'revision': 'src@%s' % revision,
                 'bot': bot_name,
                 'name': build_request_id
                }
     # Update patch information if supplied.
     if patch:
       job_args['patch'] = patch
     # Posts job to build the revision on the server.
-    if post_perf_builder_job.PostTryJob(job_args):
+    if bisect_builder.PostTryJob(job_args):
       poll_interval = 60
+      status_check_interval = 600
+      last_status_check = time.time()
       start_time = time.time()
       while True:

[qyearsley, 2014/05/23 23:17:16]

Suggestion: Would it be clearer if this wait-loop were extracted out to its own
function?

         res = condition()

[qyearsley, 2014/05/23 23:17:16]

It's not obvious here that this condition function is actually trying to fetch
from cloud storage -- it might be clearer if you renamed this condition argument
and added something in the docstring about what it's expected to do.

         if res:
           return res
+        elapsed_status_check = time.time() - last_status_check
+        # To avoid overloading tryserver with status check requests, we check
+        # build status for every 10 mins.
+        if elapsed_status_check > status_check_interval:
+          last_status_check = time.time()
+          if not build_num:
+            # Get the build number on tryserver for the current build.
+            build_num = bisect_builder.GetBuildNumFromBuilder(
+                build_request_id, bot_name, builder_host, builder_port)
+          # Check the status of build using the build number.
+          # Note: Build is treated as PENDING if build number is not found
+          # on the the tryserver.
+          build_status, status_link = bisect_builder.GetBuildStatus(
+              build_num, bot_name, builder_host, builder_port)
+          if build_status == bisect_builder.FAILED:
+            raise RuntimeError('Failed to build revision %s, status link %s.' %
+                (revision, status_link))
         elapsed_time = time.time() - start_time
         if elapsed_time > build_timeout:
           raise RuntimeError('Timed out while waiting %ds for %s build.' %
                              (build_timeout, revision))
         print ('Time elapsed: %ss, still waiting for %s build' %
                (elapsed_time, revision))
         time.sleep(poll_interval)
     return False
 
   def IsDownloadable(self, depot):
@@ skipping 2234 matching lines @@
       # The perf dashboard scrapes the "results" step in order to comment on
       # bugs. If you change this, please update the perf dashboard as well.
       bisect_utils.OutputAnnotationStepStart('Results')
     print 'Error: %s' % e.message
     if opts.output_buildbot_annotations:
       bisect_utils.OutputAnnotationStepClosed()
   return 1
 
 if __name__ == '__main__':
   sys.exit(main())