Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: content/network/network_context.h

Issue 2951293002: NetworkService: Destroy URLLoaders when a NetworkContext is destroyed. (Closed)
Patch Set: Response to comment, change why destruction is safe Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/test_url_loader_client.cc ('k') | content/network/network_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/network/network_context.h
diff --git a/content/network/network_context.h b/content/network/network_context.h
index 51834fe5295b24ad41af5e150606cfcc99849508..a4dd42c2b6808c637e36c76dc9dc485e275ca189 100644
--- a/content/network/network_context.h
+++ b/content/network/network_context.h
@@ -62,10 +62,6 @@ class NetworkContext : public mojom::NetworkContext {
// net::URLRequestContext (held by NetworkContext) is destroyed.
std::set<URLLoaderImpl*> url_loaders_;
- // Set when entering the destructor, in order to avoid manipulations of the
- // |url_loaders_| (as a url_loader might delete itself in Cleanup()).
- bool in_shutdown_;
-
mojom::NetworkContextParamsPtr params_;
mojo::Binding<mojom::NetworkContext> binding_;
« no previous file with comments | « content/browser/loader/test_url_loader_client.cc ('k') | content/network/network_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698