Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: extensions/common/file_util.cc

Issue 295123002: Provide script/gypi support for manifest generation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Support Jinja2. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/file_util.cc
diff --git a/extensions/common/file_util.cc b/extensions/common/file_util.cc
index 0a116ad329570d9bc13e45fe366a5ae12126c4fc..8f025dbc916696a356fb22588ee99bf1a61044eb 100644
--- a/extensions/common/file_util.cc
+++ b/extensions/common/file_util.cc
@@ -155,7 +155,14 @@ scoped_refptr<Extension> LoadExtension(const base::FilePath& extension_path,
base::DictionaryValue* LoadManifest(const base::FilePath& extension_path,
std::string* error) {
- base::FilePath manifest_path = extension_path.Append(kManifestFilename);
+ return LoadManifest(extension_path, kManifestFilename, error);
+}
+
+base::DictionaryValue* LoadManifest(
+ const base::FilePath& extension_path,
+ const base::FilePath::CharType* manifest_filename,
+ std::string* error) {
+ base::FilePath manifest_path = extension_path.Append(manifest_filename);
if (!base::PathExists(manifest_path)) {
*error = l10n_util::GetStringUTF8(IDS_EXTENSION_MANIFEST_UNREADABLE);
return NULL;

Powered by Google App Engine
This is Rietveld 408576698