Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2951223002: [EasyUnlock] Display a timeout state when the device isn't connected after a long time. (Closed)

Created:
3 years, 6 months ago by Tim Song
Modified:
3 years, 5 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Display a timeout state when the device isn't connected after a long time. BUG=726792 Review-Url: https://codereview.chromium.org/2951223002 Cr-Commit-Position: refs/heads/master@{#484801} Committed: https://chromium.googlesource.com/chromium/src/+/3fc9e0b56e8a5426b6d5c33fb9df67e618bbb48e

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M components/proximity_auth/unlock_manager_impl.cc View 1 3 chunks +13 lines, -11 lines 0 comments Download
M components/proximity_auth/unlock_manager_impl_unittest.cc View 1 3 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Tim Song
3 years, 6 months ago (2017-06-21 23:49:30 UTC) #2
sacomoto
https://codereview.chromium.org/2951223002/diff/1/components/proximity_auth/unlock_manager_impl.cc File components/proximity_auth/unlock_manager_impl.cc (right): https://codereview.chromium.org/2951223002/diff/1/components/proximity_auth/unlock_manager_impl.cc#newcode368 components/proximity_auth/unlock_manager_impl.cc:368: if (is_waking_up_) Why don't want you the AUTHENTICATING and ...
3 years, 6 months ago (2017-06-22 15:49:11 UTC) #3
Tim Song
https://codereview.chromium.org/2951223002/diff/1/components/proximity_auth/unlock_manager_impl.cc File components/proximity_auth/unlock_manager_impl.cc (right): https://codereview.chromium.org/2951223002/diff/1/components/proximity_auth/unlock_manager_impl.cc#newcode368 components/proximity_auth/unlock_manager_impl.cc:368: if (is_waking_up_) On 2017/06/22 15:49:11, sacomoto wrote: > Why ...
3 years, 6 months ago (2017-06-22 20:52:11 UTC) #4
sacomoto
lgtm https://codereview.chromium.org/2951223002/diff/1/components/proximity_auth/unlock_manager_impl.cc File components/proximity_auth/unlock_manager_impl.cc (right): https://codereview.chromium.org/2951223002/diff/1/components/proximity_auth/unlock_manager_impl.cc#newcode368 components/proximity_auth/unlock_manager_impl.cc:368: if (is_waking_up_) On 2017/06/22 20:52:11, Tim Song wrote: ...
3 years, 5 months ago (2017-06-26 11:45:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951223002/1
3 years, 5 months ago (2017-06-27 21:33:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/416514)
3 years, 5 months ago (2017-06-27 22:06:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951223002/20001
3 years, 5 months ago (2017-07-06 22:18:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/304327)
3 years, 5 months ago (2017-07-06 23:17:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951223002/20001
3 years, 5 months ago (2017-07-07 00:13:50 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 02:29:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3fc9e0b56e8a5426b6d5c33fb9df...

Powered by Google App Engine
This is Rietveld 408576698