Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2951213002: Remove API_TIMELINE_DURATION from Dart_ReadKernelBinary. (Closed)

Created:
3 years, 6 months ago by sivachandra
Modified:
3 years, 6 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove API_TIMELINE_DURATION from Dart_ReadKernelBinary. This allows Dart_ReadKernelBinary to be called before Dart_Initialize. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/2883d7f416296b8b7c031fb4c2d5e862b40894d4

Patch Set 1 #

Patch Set 2 : Explain why #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sivachandra
3 years, 6 months ago (2017-06-21 23:10:13 UTC) #3
rmacnak
lgtm Add a note to the commit message that it is because we want to ...
3 years, 6 months ago (2017-06-21 23:11:49 UTC) #4
sivachandra
3 years, 6 months ago (2017-06-21 23:15:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2883d7f416296b8b7c031fb4c2d5e862b40894d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698