Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7023)

Unified Diff: chrome/android/java/res/layout/title_button_menu_item.xml

Issue 2951133003: Clean up tinted ImageView subclasses (Closed)
Patch Set: Comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/menu_item.xml ('k') | chrome/android/java/res/layout/update_menu_item.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/title_button_menu_item.xml
diff --git a/chrome/android/java/res/layout/title_button_menu_item.xml b/chrome/android/java/res/layout/title_button_menu_item.xml
index f993c840ebdf24a54c39a37c3cf3da50c9a012d2..3edbfabe44d8698950aa67f5c5346dd09ddf246f 100644
--- a/chrome/android/java/res/layout/title_button_menu_item.xml
+++ b/chrome/android/java/res/layout/title_button_menu_item.xml
@@ -4,6 +4,12 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
+
+<!-- Represents a menu item that can display any of the following options:
+ * A text label
+ * A text label with a checkbox indicating that it is enabled or disabled
+ * A text label with an icon
+-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:chrome="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
@@ -21,6 +27,21 @@
android:singleLine="true"
android:textAppearance="?android:attr/textAppearanceLargePopupMenu" />
+ <!-- Checkbox. Paddings account for built-in padding from the Android resource. -->
+ <org.chromium.chrome.browser.appmenu.AppMenuItemIcon
+ android:id="@+id/checkbox"
+ android:layout_width="56dp"
+ android:layout_height="match_parent"
+ android:background="?attr/listChoiceBackgroundIndicator"
+ android:paddingStart="12dp"
+ android:paddingEnd="12dp"
+ android:paddingTop="8dp"
+ android:paddingBottom="8dp"
+ android:scaleType="fitCenter"
+ android:src="?android:attr/listChoiceIndicatorMultiple"
+ chrome:chrometint="@null" />
+
+ <!-- Displays an icon. -->
<org.chromium.chrome.browser.widget.TintedImageButton
android:id="@+id/button"
android:layout_width="56dp"
« no previous file with comments | « chrome/android/java/res/layout/menu_item.xml ('k') | chrome/android/java/res/layout/update_menu_item.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698