Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

Issue 2951133003: Clean up tinted ImageView subclasses (Closed)
Patch Set: Comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.customtabs; 5 package org.chromium.chrome.browser.customtabs;
6 6
7 import android.view.Menu; 7 import android.view.Menu;
8 import android.view.MenuItem; 8 import android.view.MenuItem;
9 9
10 import org.chromium.base.VisibleForTesting; 10 import org.chromium.base.VisibleForTesting;
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 ShareHelper.configureDirectShareMenuItem( 75 ShareHelper.configureDirectShareMenuItem(
76 mActivity, menu.findItem(R.id.direct_share_menu_id)); 76 mActivity, menu.findItem(R.id.direct_share_menu_id));
77 } 77 }
78 78
79 MenuItem iconRow = menu.findItem(R.id.icon_row_menu_id); 79 MenuItem iconRow = menu.findItem(R.id.icon_row_menu_id);
80 MenuItem openInChromeItem = menu.findItem(R.id.open_in_browser_id); 80 MenuItem openInChromeItem = menu.findItem(R.id.open_in_browser_id);
81 MenuItem bookmarkItem = menu.findItem(R.id.bookmark_this_page_id); 81 MenuItem bookmarkItem = menu.findItem(R.id.bookmark_this_page_id);
82 MenuItem downloadItem = menu.findItem(R.id.offline_page_id); 82 MenuItem downloadItem = menu.findItem(R.id.offline_page_id);
83 83
84 boolean addToHomeScreenVisible = true; 84 boolean addToHomeScreenVisible = true;
85 85 updateRequestDesktopSiteMenuItem(menu, currentTab);
86 // Hide request desktop site on all chrome:// pages except for the N TP. Check request
87 // desktop site if it's activated on this page.
88 MenuItem requestItem = menu.findItem(R.id.request_desktop_site_id);
89 updateRequestDesktopSiteMenuItem(requestItem, currentTab);
90 86
91 if (mIsMediaViewer) { 87 if (mIsMediaViewer) {
92 // Most of the menu items don't make sense when viewing media. 88 // Most of the menu items don't make sense when viewing media.
93 iconRow.setVisible(false); 89 iconRow.setVisible(false);
94 openInChromeItem.setVisible(false); 90 openInChromeItem.setVisible(false);
95 menu.findItem(R.id.find_in_page_id).setVisible(false); 91 menu.findItem(R.id.find_in_page_id).setVisible(false);
96 menu.findItem(R.id.request_desktop_site_id).setVisible(false); 92 menu.findItem(R.id.request_desktop_site_row_menu_id).setVisible( false);
97 addToHomeScreenVisible = false; 93 addToHomeScreenVisible = false;
98 } else if (mIsPaymentRequestUI) { 94 } else if (mIsPaymentRequestUI) {
99 // Only the icon row and 'find in page' are shown for openning p ayment request UI 95 // Only the icon row and 'find in page' are shown for openning p ayment request UI
100 // from Chrome. 96 // from Chrome.
101 openInChromeItem.setVisible(false); 97 openInChromeItem.setVisible(false);
102 menu.findItem(R.id.request_desktop_site_id).setVisible(false); 98 menu.findItem(R.id.request_desktop_site_id).setVisible(false);
103 addToHomeScreenVisible = false; 99 addToHomeScreenVisible = false;
104 } else { 100 } else {
105 openInChromeItem.setTitle( 101 openInChromeItem.setTitle(
106 DefaultBrowserInfo.getTitleOpenInDefaultBrowser(mIsOpene dByChrome)); 102 DefaultBrowserInfo.getTitleOpenInDefaultBrowser(mIsOpene dByChrome));
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 * the same title, a random one will be returned. This method is for testing purpose _only_. 154 * the same title, a random one will be returned. This method is for testing purpose _only_.
159 */ 155 */
160 @VisibleForTesting 156 @VisibleForTesting
161 MenuItem getMenuItemForTitle(String title) { 157 MenuItem getMenuItemForTitle(String title) {
162 for (MenuItem item : mItemToIndexMap.keySet()) { 158 for (MenuItem item : mItemToIndexMap.keySet()) {
163 if (item.getTitle().equals(title)) return item; 159 if (item.getTitle().equals(title)) return item;
164 } 160 }
165 return null; 161 return null;
166 } 162 }
167 } 163 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698