Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2951133002: Mostly revert "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host… (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mostly revert "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries." This reverts commit 9ab39ae09987c16a6d5488162c4d7400dd47e04c. Keep removal of bad assert in loader.dart. Keep using script snapshot in cross builds. We expect to use a checked-in SDK in the Fuschia build instead. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/1eee6d8af362751d150a73c7d6e814e3c02d6069

Patch Set 1 #

Total comments: 1

Patch Set 2 : gn format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -169 lines) Patch
M runtime/BUILD.gn View 6 chunks +21 lines, -47 lines 0 comments Download
M runtime/bin/BUILD.gn View 4 chunks +50 lines, -68 lines 0 comments Download
M runtime/observatory/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/vm/BUILD.gn View 9 chunks +0 lines, -42 lines 0 comments Download
M utils/dartanalyzer/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download
M utils/generate_patch_sdk.gni View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmacnak
3 years, 6 months ago (2017-06-21 21:39:55 UTC) #3
zra
https://codereview.chromium.org/2951133002/diff/1/utils/application_snapshot.gni File utils/application_snapshot.gni (right): https://codereview.chromium.org/2951133002/diff/1/utils/application_snapshot.gni#newcode31 utils/application_snapshot.gni:31: extra_inputs = [main_dart] We should probably keep the formatting ...
3 years, 6 months ago (2017-06-21 21:46:51 UTC) #4
rmacnak
On 2017/06/21 21:46:51, zra wrote: > https://codereview.chromium.org/2951133002/diff/1/utils/application_snapshot.gni > File utils/application_snapshot.gni (right): > > https://codereview.chromium.org/2951133002/diff/1/utils/application_snapshot.gni#newcode31 > ...
3 years, 6 months ago (2017-06-21 22:08:59 UTC) #5
zra
lgtm
3 years, 6 months ago (2017-06-21 22:10:22 UTC) #6
rmacnak
3 years, 6 months ago (2017-06-21 22:19:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1eee6d8af362751d150a73c7d6e814e3c02d6069 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698