On 2017/08/09 16:08:22, Navid Zolghadr wrote:
> Is this place alright for the mojom file?
We discussed collectively. In the short term, having this here is (reluctantly)
acceptable but in the fullness of time when all Chrome implementations use the
services/ui window server (i.e. mus), the interface should get relocated to
services/ui/public/
The reasoning behind this is that this interface is part (or associated with)
the WindowTreeClient interface. In a mus context, a client would specify this
interface via its WindowTree interface (exact plumbing to be worked out over
time.)
So: please add an appropriate TODO
On 2017/08/14 18:26:58, rjkroege wrote:
> On 2017/08/09 16:08:22, Navid Zolghadr wrote:
> > Is this place alright for the mojom file?
>
> We discussed collectively. In the short term, having this here is
(reluctantly)
> acceptable but in the fullness of time when all Chrome implementations use the
> services/ui window server (i.e. mus), the interface should get relocated to
> services/ui/public/
>
> The reasoning behind this is that this interface is part (or associated with)
> the WindowTreeClient interface. In a mus context, a client would specify this
> interface via its WindowTree interface (exact plumbing to be worked out over
> time.)
>
> So: please add an appropriate TODO
Done.
2
3 import "ui/gfx/geometry/mojo/geometry.mojom";
4
5 // Returns the hit-tested remote frame id for the given coordinates.
6 interface FrameInputHitTest {
rjkroege
2017/08/14 18:26:58
I am opposed to this name. The "Test" suffix sugge
I am opposed to this name. The "Test" suffix suggests test code. I called this
"immediate" mode in the initial design doc but it's actually a delegate pattern
so I'm going to suggest calling this something like TargetFrameForInputDelegate
(and file name should match.)
On 2017/08/14 18:26:58, rjkroege wrote:
> I am opposed to this name. The "Test" suffix suggests test code. I called this
> "immediate" mode in the initial design doc but it's actually a delegate
pattern
> so I'm going to suggest calling this something like
TargetFrameForInputDelegate
> (and file name should match.)
Issue 2951053005: Add Mojo API for Blink hit testing
(Closed)
Created 3 years, 6 months ago by Navid Zolghadr
Modified 3 years, 3 months ago
Reviewers: rjkroege, kenrb, dcheng, riajiang, bokan, dtapuska, sadrul
Base URL:
Comments: 16