Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: components/security_state/content/content_utils.cc

Issue 2951043002: Prepare security bullets for Android: add issuer and change connection details. (Closed)
Patch Set: Typo Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/content/content_utils.cc
diff --git a/components/security_state/content/content_utils.cc b/components/security_state/content/content_utils.cc
index f1dc1154b861fd39b2d3dbb037c948a372caf253..343272217cb70270edda1b19b5c78fecaa2df2d9 100644
--- a/components/security_state/content/content_utils.cc
+++ b/components/security_state/content/content_utils.cc
@@ -112,19 +112,19 @@ void AddConnectionExplanation(
str_id = (status & net::OBSOLETE_SSL_MASK_PROTOCOL)
? IDS_SSL_AN_OBSOLETE_PROTOCOL
: IDS_SSL_A_STRONG_PROTOCOL;
- description_replacements.push_back(l10n_util::GetStringUTF16(str_id));
description_replacements.push_back(protocol_name);
+ description_replacements.push_back(l10n_util::GetStringUTF16(str_id));
str_id = (status & net::OBSOLETE_SSL_MASK_KEY_EXCHANGE)
? IDS_SSL_AN_OBSOLETE_KEY_EXCHANGE
: IDS_SSL_A_STRONG_KEY_EXCHANGE;
- description_replacements.push_back(l10n_util::GetStringUTF16(str_id));
description_replacements.push_back(key_exchange_name);
+ description_replacements.push_back(l10n_util::GetStringUTF16(str_id));
str_id = (status & net::OBSOLETE_SSL_MASK_CIPHER) ? IDS_SSL_AN_OBSOLETE_CIPHER
: IDS_SSL_A_STRONG_CIPHER;
- description_replacements.push_back(l10n_util::GetStringUTF16(str_id));
description_replacements.push_back(cipher_name);
+ description_replacements.push_back(l10n_util::GetStringUTF16(str_id));
security_style_explanations->info_explanations.push_back(
content::SecurityStyleExplanation(
@@ -297,12 +297,26 @@ blink::WebSecurityStyle GetSecurityStyle(
} else {
// If the certificate does not have errors and is not using SHA1, then add
// an explanation that the certificate is valid.
+
+ base::string16 issuer_name;
+ if (security_info.certificate) {
+ // This results in the empty string if there is no relevant display name.
+ issuer_name = base::UTF8ToUTF16(
+ security_info.certificate->issuer().GetDisplayName());
+ } else {
+ issuer_name = base::string16();
+ }
+ if (issuer_name.empty()) {
+ issuer_name.assign(
+ l10n_util::GetStringUTF16(IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY));
+ }
+
if (!security_info.sha1_in_chain) {
security_style_explanations->secure_explanations.push_back(
content::SecurityStyleExplanation(
l10n_util::GetStringUTF8(IDS_VALID_SERVER_CERTIFICATE),
- l10n_util::GetStringUTF8(
- IDS_VALID_SERVER_CERTIFICATE_DESCRIPTION),
+ l10n_util::GetStringFUTF8(
+ IDS_VALID_SERVER_CERTIFICATE_DESCRIPTION, issuer_name),
!!security_info.certificate));
}
}

Powered by Google App Engine
This is Rietveld 408576698