Separate RendererCdmManager from RendererMediaPlayerManager.

content/renderer/media/android/webmediaplayer_android.h

Index: content/renderer/media/android/webmediaplayer_android.h
diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h
index 587e54c095476795351389d51ac3815259007469..70388afb3003e609cc860b2c6a0b7b6a6bc97b5b 100644
--- a/content/renderer/media/android/webmediaplayer_android.h
+++ b/content/renderer/media/android/webmediaplayer_android.h
@@ -54,6 +54,7 @@ class WebLayerImpl;
 }
 
 namespace content {
+class RendererCdmManager;
 class RendererMediaPlayerManager;
 class WebContentDecryptionModuleImpl;
 class WebMediaPlayerDelegate;
@@ -75,7 +76,8 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
   WebMediaPlayerAndroid(blink::WebFrame* frame,
                         blink::WebMediaPlayerClient* client,
                         base::WeakPtr<WebMediaPlayerDelegate> delegate,
-                        RendererMediaPlayerManager* manager,
+                        RendererMediaPlayerManager* player_manager,
+                        RendererCdmManager* cdm_manager,
                         scoped_refptr<StreamTextureFactory> factory,
                         const scoped_refptr<base::MessageLoopProxy>& media_loop,
                         media::MediaLog* media_log);
@@ -336,9 +338,14 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
 
   // Manager for managing this object and for delegating method calls on
   // Render Thread.
-  RendererMediaPlayerManager* manager_;
+  RendererMediaPlayerManager* player_manager_;
 
-  // Player ID assigned by the |manager_|.
+  // Manager for managing CDMs on the Render Thread.

[ddorwin, 2014/05/23 23:28:37]

nit: "Manager for managing" is redundant. "Manages CDMs.."?
Same above.

[xhwang, 2014/05/27 22:57:41]

Done.

+  // TODO(xhwang): Remove |cdm_manager_| when prefixed EME is deprecated. See
+  // http://crbug.com/249976
+  RendererCdmManager* cdm_manager_;

[ddorwin, 2014/05/23 23:28:37]

Should we explain who owns these?

[xhwang, 2014/05/27 22:57:41]

Done.

+
+  // Player ID assigned by the |player_manager_|.
   int player_id_;
 
   // Current player states.
@@ -440,7 +447,7 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
   // This is only Used by Clear Key key system implementation, where a renderer
   // side CDM will be used. This is similar to WebMediaPlayerImpl. For other key
   // systems, a browser side CDM will be used and we set CDM by calling
-  // manager_->SetCdm() directly.
+  // player_manager_->SetCdm() directly.
   media::DecryptorReadyCB decryptor_ready_cb_;
 
   // NOTE: Weak pointers must be invalidated before all other member variables.