Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 295103015: Separate RendererCdmManager from RendererMediaPlayerManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ready for review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 class NotificationProvider; 62 class NotificationProvider;
63 class PepperPluginInstanceImpl; 63 class PepperPluginInstanceImpl;
64 class RendererPpapiHost; 64 class RendererPpapiHost;
65 class RenderFrameObserver; 65 class RenderFrameObserver;
66 class RenderViewImpl; 66 class RenderViewImpl;
67 class RenderWidget; 67 class RenderWidget;
68 class RenderWidgetFullscreenPepper; 68 class RenderWidgetFullscreenPepper;
69 struct CustomContextMenuContext; 69 struct CustomContextMenuContext;
70 70
71 #if defined(OS_ANDROID) 71 #if defined(OS_ANDROID)
72 class RendererCdmManager;
72 class RendererMediaPlayerManager; 73 class RendererMediaPlayerManager;
73 #endif 74 #endif
74 75
75 class CONTENT_EXPORT RenderFrameImpl 76 class CONTENT_EXPORT RenderFrameImpl
76 : public RenderFrame, 77 : public RenderFrame,
77 NON_EXPORTED_BASE(public blink::WebFrameClient), 78 NON_EXPORTED_BASE(public blink::WebFrameClient),
78 NON_EXPORTED_BASE(public WebMediaPlayerDelegate) { 79 NON_EXPORTED_BASE(public WebMediaPlayerDelegate) {
79 public: 80 public:
80 // Creates a new RenderFrame. |render_view| is the RenderView object that this 81 // Creates a new RenderFrame. |render_view| is the RenderView object that this
81 // frame belongs to. 82 // frame belongs to.
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 // Initializes |media_stream_client_|, returning true if successful. Returns 523 // Initializes |media_stream_client_|, returning true if successful. Returns
523 // false if it wasn't possible to create a MediaStreamClient (e.g., WebRTC is 524 // false if it wasn't possible to create a MediaStreamClient (e.g., WebRTC is
524 // disabled) in which case |media_stream_client_| is NULL. 525 // disabled) in which case |media_stream_client_| is NULL.
525 bool InitializeMediaStreamClient(); 526 bool InitializeMediaStreamClient();
526 527
527 blink::WebMediaPlayer* CreateWebMediaPlayerForMediaStream( 528 blink::WebMediaPlayer* CreateWebMediaPlayerForMediaStream(
528 const blink::WebURL& url, 529 const blink::WebURL& url,
529 blink::WebMediaPlayerClient* client); 530 blink::WebMediaPlayerClient* client);
530 531
531 #if defined(OS_ANDROID) 532 #if defined(OS_ANDROID)
532 blink::WebMediaPlayer* CreateAndroidWebMediaPlayer( 533 blink::WebMediaPlayer* CreateAndroidWebMediaPlayer(
533 const blink::WebURL& url, 534 const blink::WebURL& url,
534 blink::WebMediaPlayerClient* client); 535 blink::WebMediaPlayerClient* client);
535 536
536 RendererMediaPlayerManager* GetMediaPlayerManager(); 537 RendererMediaPlayerManager* GetMediaPlayerManager();
538 RendererCdmManager* GetCdmManager();
537 #endif 539 #endif
538 540
539 // Stores the WebLocalFrame we are associated with. 541 // Stores the WebLocalFrame we are associated with.
540 blink::WebLocalFrame* frame_; 542 blink::WebLocalFrame* frame_;
541 543
542 base::WeakPtr<RenderViewImpl> render_view_; 544 base::WeakPtr<RenderViewImpl> render_view_;
543 int routing_id_; 545 int routing_id_;
544 bool is_swapped_out_; 546 bool is_swapped_out_;
545 // RenderFrameProxy exists only when is_swapped_out_ is true. 547 // RenderFrameProxy exists only when is_swapped_out_ is true.
546 // TODO(nasko): This can be removed once we don't have a swapped out state on 548 // TODO(nasko): This can be removed once we don't have a swapped out state on
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 // references. 599 // references.
598 600
599 // Holds a reference to the service which provides desktop notifications. 601 // Holds a reference to the service which provides desktop notifications.
600 NotificationProvider* notification_provider_; 602 NotificationProvider* notification_provider_;
601 603
602 // MediaStreamClient attached to this frame; lazily initialized. 604 // MediaStreamClient attached to this frame; lazily initialized.
603 MediaStreamClient* media_stream_client_; 605 MediaStreamClient* media_stream_client_;
604 blink::WebUserMediaClient* web_user_media_client_; 606 blink::WebUserMediaClient* web_user_media_client_;
605 607
606 #if defined(OS_ANDROID) 608 #if defined(OS_ANDROID)
607 // Manages all media players in this render frame for communicating with the 609 // Manages all media players and CDMs in this render frame for communicating
ddorwin 2014/05/23 23:28:37 nit: These manage...
xhwang 2014/05/27 22:57:41 Done.
608 // real media player and CDM objects in the browser process. It's okay to use 610 // with the real media player and CDM objects in the browser process. It's
609 // raw pointers since it's a RenderFrameObserver. 611 // okay to use raw pointers since they are RenderFrameObservers.
610 RendererMediaPlayerManager* media_player_manager_; 612 RendererMediaPlayerManager* media_player_manager_;
613 RendererCdmManager* cdm_manager_;
611 #endif 614 #endif
612 615
613 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 616 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
614 617
615 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 618 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
616 }; 619 };
617 620
618 } // namespace content 621 } // namespace content
619 622
620 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 623 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698